fix(security): 2 improvements across 1 files#1176
Open
andoan16 wants to merge 1 commit into
Open
Conversation
- Security: Hardcoded S3 Bucket Region in Image Loader - Security: Missing Error Handling in S3 Image Loader Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com>
|
conico974
requested changes
Jun 1, 2026
| name: "s3", | ||
| load: async (key: string) => { | ||
| const s3Client = new S3Client({ logger: awsLogger }); | ||
| const s3Client = new S3Client({ region: S3_REGION || 'us-east-1', logger: awsLogger }); |
Contributor
There was a problem hiding this comment.
The function is deployed on lambda, the region is set there. We should absolutely not set it to us-east-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(security): 2 improvements across 1 files
Problem
Severity:
Medium| File:packages/open-next/src/overrides/imageLoader/s3.ts:L10The S3 image loader has a hardcoded region 'us-east-1' which could lead to issues if the bucket is in a different region. This should be configurable via environment variables.
Solution
Replace the hardcoded region with an environment variable like process.env.S3_REGION || 'us-east-1'
Changes
packages/open-next/src/overrides/imageLoader/s3.ts(modified)Testing