fix(image-optimization): Workaround for broken symlink dereferencing in Node 22.17.0 and 22.17.1 #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Node 22.17.0 and 22.17.1
🦋 Changeset detectedLatest commit: 21efa91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
reviewed
Jul 27, 2025
vicb
reviewed
Jul 28, 2025
|
Thanks for the reviews! Could you take another look when you have time Nico? We could in theory just skip the |
This was referenced Jul 29, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #933
The
dereference: trueoption infs.cpSync()is broken on Node version 22.17.0 and 22.17.1. This fix will do it manually for the binaries innode_modules/.bin. We can revert this once fixed upstream. I guess we could in theory just skip these files aswell, as they probably wont be used.npm installwill create symbolic links by default for binaries innode_modules/.bin. I tried usingbin-linksinnpm installbut I did not get it to work with our command.