Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to jhove module geotiff-GeoTiffStrings #321

Open
wants to merge 6 commits into
base: integration
Choose a base branch
from
Open

fixes to jhove module geotiff-GeoTiffStrings #321

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2018

Several Bugs have been found in current GeoTiff-extraction of jhove-module:tiff:geotiff

jhove-modules/src/main/java/edu/harvard/hul/ois/jhove/module/tiff/GeoTiffStrings.java

For example

  • double keys (due to copy&paste-error already at the source website)

GeoTiffStrings.java:

...26774, 26774,
26775, 26775, 26776, 26776, 26777, 26777,...

online resource (http://geotiff.maptools.org/spec/geotiff6.html):

PCS_NAD27_BLM_14N_feet = 26774

PCS_NAD27_Indiana_West = 26774

PCS_NAD27_BLM_15N_feet = 26775

PCS_NAD27_Iowa_North = 26775

PCS_NAD27_BLM_16N_feet = 26776

PCS_NAD27_Iowa_South = 26776

PCS_NAD27_BLM_17N_feet = 26777

PCS_NAD27_Kansas_North = 26777

  • missing code pair's: 16k-keys in PROJECTION

e.g. 16125 = UTM zone 25S

already missing in online resource: (http://geotiff.maptools.org/spec/geotiff6.html)

but is defined in online resource: (https://sno.phy.queensu.ca/~phil/exiftool/TagNames/GeoTiff.html)

  • also differenting array sizes of index and mapped strings, which leads to wrong mapping

Work

created a java project that parses the code-pairs from both mentioned websites

Then

  • printout the array-code for GeoTiffStrings.java
  • Tests the result of GeoTiffStrings.java for array-sizes and chosen keyvalue-pairs

jhove-modules/src/test/java/edu/harvard/hul/ois/jhove/module/tiff/GeoTiffStringsTest.java

The whole project can be found here:

https://github.com/VinzenzBauer/geotiff_htmlparser4jhove.git

@carlwilson carlwilson self-assigned this May 22, 2018
@carlwilson carlwilson added the bug A product defect that needs fixing label May 22, 2018
@carlwilson carlwilson self-requested a review December 11, 2018 12:23
@carlwilson carlwilson assigned ghost and unassigned carlwilson Dec 11, 2018
@carlwilson
Copy link
Member

Closes #368

@carlwilson carlwilson added this to the v1.22-m3 Reviewed milestone Dec 19, 2018
@carlwilson carlwilson removed the bug A product defect that needs fixing label Dec 19, 2018
carlwilson and others added 2 commits January 17, 2019 10:28
…ode 25833 in ProjectedCSType was unknown to JHOVE, even with the last pullrequest
@ghost
Copy link
Author

ghost commented Jan 24, 2019

In our latest Test of Geotiff we came across a GeoTiff Code 25833.
Which is currently unknown to JHOVE - output:
ProjectedCSType: 25833
This code is within the range of the defined section of Projected CS Type:
[20000, 32760] = EPSG Projection System codes
Therefore it should be added to the internal geotiff-string-database. I'v added a 3rd source for collecting those pairs, because the first 2 obviously where not enough.
Both sources:

have no information about this specific Code, but:

does contain this information. Also a lot of other pairs which were unknown before.
The only part that i see critical is the fact that there are a lot of pairs outside the predefined ranges of geotiff-spec 1.0. All Codes that are not inside the defined ranges are currently not collected. Which should be open for Discussion.

Anyway the new data-set should improve the mapping of codes for the geotiff-module in jhove even more.

rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
@carlwilson carlwilson modified the milestones: v1.22-m2 Ready, JHOVE 1.28 Nov 30, 2022
@carlwilson carlwilson removed this from the JHOVE 1.28 milestone Jun 21, 2023
@carlwilson carlwilson self-assigned this Aug 22, 2024
@carlwilson carlwilson modified the milestones: JHOVE 1.32, JHOVE 1.34 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant