Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: XHTML DTD detection #941

Merged
merged 1 commit into from
Aug 14, 2024
Merged

FIX: XHTML DTD detection #941

merged 1 commit into from
Aug 14, 2024

Conversation

carlwilson
Copy link
Member

  • fixed issue affecting DTD detection for XHTML documents;
    • this needed extra cases adding for each of the XHTML DTD definitions;
  • added string constant for XHTML 1.1; and
  • added test cases for DTD detection with and without XML declaration.

Closes #904

- fixed issue affecting DTD detection for XHTML documents;
  - this needed extra cases adding for each of the XHTML DTD definitions;
- added string constant for XHTML 1.1; and
- added test cases for DTD detection with and without XML declaration.

Closes #904
@carlwilson carlwilson added the bug A product defect that needs fixing label Aug 14, 2024
@carlwilson carlwilson added this to the JHOVE 1.32 milestone Aug 14, 2024
@carlwilson carlwilson self-assigned this Aug 14, 2024
@carlwilson carlwilson merged commit cbeae3a into integration Aug 14, 2024
6 checks passed
@carlwilson carlwilson deleted the fix/XHMTL-DTD branch September 3, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect processing of XHTML if XML declaration is missing?
1 participant