Skip to content

Comments

Migrate to io.hypersistence:hypersistence-utils-hibernate:6 types#9

Closed
AlekSimpson wants to merge 9 commits intomainfrom
alek/fixIssueThree
Closed

Migrate to io.hypersistence:hypersistence-utils-hibernate:6 types#9
AlekSimpson wants to merge 9 commits intomainfrom
alek/fixIssueThree

Conversation

@AlekSimpson
Copy link

What's changed?

This introduces a fix for updating @Type annotations with the proper JSON arguments.

What's your motivation?

#3 and PR #7

Anything in particular you'd like reviewers to focus on?

The import statement for io.hypersistence.utils.hibernate.type.json.JsonType does not get added in for some reason. Also the typeDefsAnnotationIsNotRemovedWhenHypersistenceUtilsAreNotBeingUsed() test now fails. My fix for the other test does not yet check if @Type is being used before removing @TypeDefs. I tried playing around with using preconditions to check for this ahead of time. That didn't quite work out though. I think maybe some sort of cursor messaging is needed for this but maybe there is a better?

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

@AlekSimpson AlekSimpson added the bug Something isn't working label Sep 14, 2023
@AlekSimpson AlekSimpson self-assigned this Sep 14, 2023
@timtebeek timtebeek changed the title Fix For Issue Three Migrate to io.hypersistence:hypersistence-utils-hibernate:6 types Sep 14, 2023
@AlekSimpson AlekSimpson marked this pull request as draft September 14, 2023 14:32
@timtebeek timtebeek removed their request for review February 13, 2024 11:10
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 12, 2025
@github-actions github-actions bot closed this Apr 21, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Stale

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants