Skip to content

ModuleHasDependencies and VersionPatterns #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MBoegers
Copy link

@MBoegers MBoegers commented Aug 8, 2025

Caution

Downstream failures! Do not merge until org.openrewrite.gradle.search.DependencyInsight in OpenRewrite/rewrite is fixed.

What's changed?

Fixed the parameter swap in ModuleHasDependency to fix configuration of delegates.

What's your motivation?

Allow preconditions on module dependencies to work with versions as well.

Anything in particular you'd like reviewers to focus on?

The real fix is to be made in openrewrite/rewrite..

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

…cies` and its delegates. Also fix the parameter swap in `ModuleHasDependency`.
@MBoegers MBoegers self-assigned this Aug 8, 2025
@MBoegers MBoegers added the bug Something isn't working label Aug 8, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Aug 8, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/dependencies/DependencyInsightTest.java
    • lines 24-25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant