added ConfigurationPropertiesDefaultValueTest for LST contains invalid nodes

[tubbynl]

What's changed?

• a extra test as example for invalid code

What's your motivation?

i recently started using the @DefaultValue annotation to add sensible defaults on config properties in combination with java records. This works (as-in, compiles, tests, and runs as expected). Only when i run OpenRewrite it fails seemingly on parsing the code.

import org.springframework.boot.context.properties.ConfigurationProperties;
import org.springframework.boot.context.properties.bind.DefaultValue;

@ConfigurationProperties("nl.tubby")
record TestTubbyProperties(
         @DefaultValue("https://www.tubby.nl") String url
) {
}

running ConfigurationPropertiesDefaultValueTest fails with the following error

LST contains erroneous nodes

  StringurlltValue("https://www.tubby.nl") String url

java.lang.IllegalStateException: LST contains erroneous nodes

  StringurlltValue("https://www.tubby.nl") String url

Anything in particular you'd like reviewers to focus on?

the parsing seems to "rewrite" the code invalidly

Have you considered any alternatives or workarounds?

• adding the file to exclusions doesnt seem to work
• remove the DefaultValue value attribute yields the same
• removing the DefaultValue annotation alltogether works

Any additional context

• rewrite-maven-plugin 6.9.0
• rewrite-spring 6.7.0

active recipes

• org.openrewrite.java.migrate.UpgradeToJava21
• org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_3
• org.openrewrite.java.testing.junit5.JUnit5BestPractices
• org.openrewrite.java.spring.boot3.SpringBoot33BestPractices

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Hoi thanks! Indeed we've been having some problems so far parsing annotated constructor arguments for records; The problem is upstream, but we can keep this test here to validate the upstream fix (and once verified likely close this PR).

[tubbynl]

Tnx @timtebeek!

as i read it's interesting change in the parsing of records :) i'll wait till a testable version is released.