No DependsOnDatabaseInitialization in Spring Framework modules
#760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
timtebeek
approved these changes
Aug 7, 2025
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
|
will quick check the CI before merging |
timtebeek
reviewed
Aug 8, 2025
...va/org/openrewrite/java/spring/boot2/DatabaseComponentAndBeanInitializationOrderingTest.java
Outdated
Show resolved
Hide resolved
|
PR blocked by false results of ModuleHasDependencies openrewrite/rewrite-java-dependencies#149 |
…lization-in-framework
…rative recipe to enable scanning recipe as precondition
timtebeek
reviewed
Aug 13, 2025
...rewrite/java/spring/boot2/DatabaseComponentAndBeanInitializationOrderingUnconditionally.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Aug 13, 2025
…entAndBeanInitializationOrderingUnconditionally.java Co-authored-by: Tim te Beek <[email protected]>
MBoegers
deleted the
boeg/stop-DependsOnDatabaseInitialization-in-framework
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
added a precondition to check the modules classpath for spring-boot dependency. Within spring framwork modules this can otherwise lead to compilation failures
What's your motivation?
Prevent the adition of
@DependsOnDatabaseInitializationin Spring Framework only modules.Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
no unit test provided due to class path pollution in tests see.
Done manual tests with CLI.
Checklist