Skip to content

Conversation

sruffatti
Copy link
Contributor

What's changed?

Spring boot 3.5 and Spring cloud 2025

What's your motivation?

Keep open source alive and current.

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Aug 25, 2025
@timtebeek timtebeek added recipe Recipe requested boot-3.5 labels Aug 25, 2025
@timtebeek timtebeek changed the title Spring boot 3.5 and Spring cloud 2025 Spring Boot 3.5 and Spring Cloud 2025 declarative migration recipes Aug 25, 2025
github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

@timtebeek
Copy link
Member

timtebeek commented Sep 2, 2025

Thanks again @sruffatti ! I've added some quick tests and uncovered an issue with the spring cloud property changes that requires a closer look before we can merge these changes here. I've traced it down to this substree: if we don't have that it all passes:

// for compatibility with yaml syntax, a spring property key will never have both a (scalar) value and also subproperties
if (newTree == tree) {
newTree = subpropertiesChangePropertyKey.getVisitor().visit(tree, ctx);
}

I've also swapped out the Maven specific recipe you had used for their Maven/Gradle agnostic counterparts.

@sruffatti
Copy link
Contributor Author

@timtebeek I pushed a change to address your unit test. Thanks for this test! Not sure I would have caught this otherwise. I will write better unit tests going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-3.5 recipe Recipe requested
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants