Skip to content

Migrate Spring Framework null annotations to JSpecify #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2025
Merged

Migrate Spring Framework null annotations to JSpecify #822

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5575f71
Add annotation replacement for Nullable in YAML config
wyfrel Nov 5, 2025
2ae1203
Add replacement for NonNull annotation in YAML
wyfrel Nov 5, 2025
3827312
Replace annotation replacement with type change
wyfrel Nov 5, 2025
e444151
Use org.openrewrite.java.jspecify.MigrateFromSpringFrameworkAnnotatio…
wyfrel Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/resources/META-INF/rewrite/spring-framework-70.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,9 @@ recipeList:
newVersion: 7.0.x
- org.openrewrite.java.testing.junit6.JUnit5to6Migration
- org.openrewrite.java.jackson.UpgradeJackson_2_3
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: 'org.springframework.lang.Nullable'
newFullyQualifiedTypeName: 'org.jspecify.annotations.Nullable'
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: 'org.springframework.lang.NonNull'
newFullyQualifiedTypeName: 'org.jspecify.annotations.NonNull'
Copy link
Member

@timtebeek timtebeek Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to use the existing recipe we have here:
https://docs.openrewrite.org/recipes/java/jspecify/migratefromspringframeworkannotations

Suggested change
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: 'org.springframework.lang.Nullable'
newFullyQualifiedTypeName: 'org.jspecify.annotations.Nullable'
- org.openrewrite.java.ChangeType:
oldFullyQualifiedTypeName: 'org.springframework.lang.NonNull'
newFullyQualifiedTypeName: 'org.jspecify.annotations.NonNull'
- org.openrewrite.java.jspecify.MigrateFromSpringFrameworkAnnotations

You'll want to add a dependency on rewrite-jackson here as well.

Copy link
Contributor Author

@wyfrel wyfrel Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timtebeek Thanks for the suggestion. The dependency on rewrite-jackson is already added by #766 correct ?