-
Notifications
You must be signed in to change notification settings - Fork 480
ANTLR-based XPathMatcher implementation
#6353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewrite-xml/src/main/java/org/openrewrite/xml/XPathMatcher.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XPathMatcher.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XPathMatcher.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XPathMatcher.java
Outdated
Show resolved
Hide resolved
rewrite-xml/src/main/java/org/openrewrite/xml/XPathMatcher.java
Outdated
Show resolved
Hide resolved
3 tasks
rewrite-xml/src/main/java/org/openrewrite/xml/XPathMatcher.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Dec 1, 2025
XPath ANTLR grammarXPathMatcher implementation
rewrite-xml/src/main/java/org/openrewrite/xml/XPathMatcher.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace regex-based XPath parsing with a proper ANTLR grammar for improved correctness, maintainability, and performance.
Key Changes
XPathLexer.g4andXPathParser.g4provide a formal grammar for the supported XPath subsetSupported XPath Features
/root/child,child/grandchild//element/root/*/@attr,/@*[@attr='value'],[child='value'],[1],[last()]local-name(),contains(),starts-with(),text(),position(),last(),not()and,orparent::,self::,..,.Test Improvements
Tests now verify exact match counts instead of just boolean existence, providing stronger validation of XPath matching behavior.