-
Couldn't load subscription status.
- Fork 6
Add/documentation #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add/documentation #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor comments; they're not a must-have but nice-to-have.
| The `PymiloServer` class facilitates streaming machine learning models over a network. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to have a short description of how the methods, element below are used as paratmers for the server
|
|
||
| #### PymiloClient | ||
|
|
||
| The `PymiloClient` class facilitates working with remote PyMilo servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
| | **Mode** | **Description** | | ||
| | -------- | --------------- | | ||
| | LOCAL | Execute operations on the local model | | ||
| | DELEGATE | Delegate operations to the remote server | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turn this into a text description, the format used here is different from other place and it can be confusing.
Reference Issues/PRs
Add API Reference of main user facing classes of PyMilo.
I tried to follow the structure we have chosen for Memor.
What does this implement/fix? Explain your changes.
Any other comments?