Skip to content

Conversation

@AHReccese
Copy link
Member

@AHReccese AHReccese commented Oct 17, 2025

Reference Issues/PRs

Add API Reference of main user facing classes of PyMilo.

I tried to follow the structure we have chosen for Memor.

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese self-assigned this Oct 17, 2025
@AHReccese AHReccese marked this pull request as ready for review October 20, 2025 16:13
@AHReccese AHReccese added the documentation Improvements or additions to documentation label Oct 20, 2025
Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments; they're not a must-have but nice-to-have.

Comment on lines +221 to +222
The `PymiloServer` class facilitates streaming machine learning models over a network.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to have a short description of how the methods, element below are used as paratmers for the server


#### PymiloClient

The `PymiloClient` class facilitates working with remote PyMilo servers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

Comment on lines +272 to +275
| **Mode** | **Description** |
| -------- | --------------- |
| LOCAL | Execute operations on the local model |
| DELEGATE | Delegate operations to the remote server |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn this into a text description, the format used here is different from other place and it can be confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants