Add Context Manager to PER #4379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingshi Liu <[email protected]> change context management passing from query parameters to payload Signed-off-by: Mingshi Liu <[email protected]> pass hook registery into PER Signed-off-by: Mingshi Liu <[email protected]> apply spotless Signed-off-by: Mingshi Liu <[email protected]> initiate context management api with hook implementation Signed-off-by: Mingshi Liu <[email protected]>
mingshl
force-pushed
the
context_manager_feature_per
branch
from
86a3623 to
67ad592
Compare
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
pyek-bot
reviewed
Oct 30, 2025
.../main/java/org/opensearch/ml/engine/algorithms/agent/MLPlanExecuteAndReflectAgentRunner.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mingshi Liu <[email protected]>
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
sam-herman,
xinyual,
ylwu-amzn and
zane-neo
as code owners
Signed-off-by: Mingshi Liu <[email protected]>
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
reviewed
Oct 31, 2025
ml-algorithms/src/main/java/org/opensearch/ml/engine/agents/AgentContextUtil.java
Show resolved
Hide resolved
ml-algorithms/src/main/java/org/opensearch/ml/engine/agents/AgentContextUtil.java
Show resolved
Hide resolved
ml-algorithms/src/main/java/org/opensearch/ml/engine/agents/AgentContextUtil.java
Outdated
Show resolved
Hide resolved
| private static final int DEFAULT_PRESERVE_RECENT_MESSAGES = 10; | ||
| private static final String DEFAULT_SUMMARIZATION_PROMPT = | ||
| "You are a tool interactions summarization agent. Summarize the provided tool interactions concisely while preserving key information and context."; | ||
| "You are a interactions summarization agent. Summarize the provided interactions concisely while preserving key information and context."; |
There was a problem hiding this comment.
Is this the expected prompt to not include Tool-Specific Details? I think this would cause some Verbose Summaries.
There was a problem hiding this comment.
we now use summarization manager for two sub agents in PER. for planner, summarization manager summarizes the completed steps, and for the executor, summarization manager summarizes the tool used results. So I try to make the prompt general to summarize interactions.
ml-algorithms/src/main/java/org/opensearch/ml/engine/agents/AgentContextUtil.java
Show resolved
Hide resolved
|
CI failed not related to code changes |
Signed-off-by: Mingshi Liu <[email protected]>
mingshl
merged commit f588a24
into
opensearch-project:feature/context_manager_hooks
5 checks passed
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
mingshl
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Context Manager to PER,
for planner agent, I added in a PRE_LLM hook, and for executor agent, which is a conversational agent, it would use the same PRE_LLM hook and POST_TOOL hook for conversational runner.
Related Issues
Add Context Manager to PER
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.