[release-v1.17] fix: cluster dialer for OCI pusher #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to push images to registry in cluster that is not exposed to the internet. Signed-off-by: Matej Vašek <[email protected]>
Collaborator
Author
|
PTAL @jrangelramos @gauron99 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
@jrangelramos have you verified this fixes problem for you? |
Collaborator
Author
|
/unhold |
openshift-merge-bot
bot
merged commit efe0111
into
release-v1.17
47 of 50 checks passed
Collaborator
Author
|
@dsimansk was this PR included in knative client release? |
Collaborator
Author
|
I think it was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow the OCI image pusher to employ in-cluster-dialer. This allows it to push an image to internal registry that is not exposed to the internet.