Skip to content

[release-4.19] CORENET-6148: Promote RouteAdvertisements feature gate to default feature set #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.19
Choose a base branch
from
Open

[release-4.19] CORENET-6148: Promote RouteAdvertisements feature gate to default feature set #2425

wants to merge 1 commit into from

Conversation

arghosh93
Copy link
Contributor

@arghosh93 arghosh93 commented Jul 28, 2025 •
edited
Loading

This PR lifts the FG for RouteAdvertisements feature.

RouteAdvertisements feature gate was lifted in 4.20 via below PR:
#2225

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2025 •
edited by openshift-ci bot
Loading

@arghosh93: This pull request references CORENET-6148 which is a valid jira issue.

In response to this:

This PR lifts the FG for RouteAdvertisements feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 28, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

Hello @arghosh93! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 28, 2025
@openshift-ci openshift-ci bot requested review from everettraven and JoelSpeed July 28, 2025 10:44
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arghosh93
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor

@arghosh93 Please link the associated SBAR in the PR description

Also, schema checker is reporting existing issues that cannot be fixed, we can override that

/override ci/prow/verify-crd-schema

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

@arghosh93 Please link the associated SBAR in the PR description

Also, schema checker is reporting existing issues that cannot be fixed, we can override that

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tssurya
Copy link
Contributor

tssurya commented Jul 28, 2025

@arghosh93 Please link the associated SBAR in the PR description

Also, schema checker is reporting existing issues that cannot be fixed, we can override that

/override ci/prow/verify-crd-schema

yea will open a SBAR and link it here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 28, 2025 •
edited by openshift-ci bot
Loading

@arghosh93: This pull request references CORENET-6148 which is a valid jira issue.

In response to this:

This PR lifts the FG for RouteAdvertisements feature.

RouteAdvertisements feature gate was lifted in 4.20 via below PR:
#2225

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@arghosh93
Copy link
Contributor Author

/hold
Till we are working on the SBAR.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2025
@sdodson
Copy link
Member

sdodson commented Aug 4, 2025

/test verify-feature-promotion

4 similar comments
@tssurya
Copy link
Contributor

tssurya commented Aug 8, 2025

/test verify-feature-promotion

@tssurya
Copy link
Contributor

tssurya commented Aug 11, 2025

/test verify-feature-promotion

@jcaamano
Copy link
Contributor

/test verify-feature-promotion

@tssurya
Copy link
Contributor

tssurya commented Aug 14, 2025

/test verify-feature-promotion

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn d68a59c link false /test okd-scos-e2e-aws-ovn
ci/prow/verify-crd-schema d68a59c link true /test verify-crd-schema
ci/prow/verify-feature-promotion d68a59c link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcaamano
Copy link
Contributor

@JoelSpeed I think these numbers do not add up

error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising a cluster user defined network [apigroup:user.openshift.io][apigroup:security.openshift.io] Over a VRF-Lite configuration Pods should be able to communicate on a secondary network [Timeout:30m] [Suite:openshift/conformance/parallel]" only has 13 runs, need at least 14 runs for "RouteAdvertisements" on {metal amd64 ha dual}
error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising a cluster user defined network [apigroup:user.openshift.io][apigroup:security.openshift.io] Over the default VRF When the network topology is Layer 2 External host should be able to query route advertised pods by the pod IP [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "RouteAdvertisements" on {metal amd64 ha dual}
error: "[sig-network][OCPFeatureGate:RouteAdvertisements][Feature:RouteAdvertisements][apigroup:operator.openshift.io] when using openshift ovn-kubernetes [PodNetwork] Advertising a cluster user defined network [apigroup:user.openshift.io][apigroup:security.openshift.io] Over the default VRF When the network topology is Layer 2 Pods should communicate with external host without being SNATed [Suite:openshift/conformance/parallel]" only has 12 runs, need at least 14 runs for "RouteAdvertisements" on {metal amd64 ha dual}

They run daily and they have been running for more than 14 days. What are we missing?

@JoelSpeed
Copy link
Contributor

If for any reason the cluster failed to come up one or two of those days, you'll have missed out on the data as the result wouldn't be recorded for a cluster bootstrapping fail.

The best thing to do here would be to work out which job you need to run to trigger those tests and use gangway-cli to trigger say 5 more runs

@jcaamano
Copy link
Contributor

If for any reason the cluster failed to come up one or two of those days, you'll have missed out on the data as the result wouldn't be recorded for a cluster bootstrapping fail.

The best thing to do here would be to work out which job you need to run to trigger those tests and use gangway-cli to trigger say 5 more runs

It's strange though that it just happens to those particular test cases if entire jobs failed to run. Will run gangway as you suggested, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven Awaiting requested review from everettraven

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arghosh93 @openshift-ci-robot @JoelSpeed @tssurya @sdodson @jcaamano