WIP: OKD-259: Support an "OKD" featureset to be enabled by default on OKD clusters #2451

jatinsu · 2025-08-12T18:50:25Z

This PR was largely bult on the work done by @Prashanth684

This first pass only includes all featuregates which are default
For OKD clusters, this would be the "default" featureset
Allows for upgrades

openshift-ci-robot · 2025-08-12T18:50:29Z

@jatinsu: This pull request references OKD-259 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

In response to this:

This PR, built largely on the work done by @Prashanth684, intends to create a OKD featureset that will be enabled by default on all OKD clusters. This will offload testing for TechPreviewNoUpgrade features to OKD and allow customers to try out new features on clusters which then can be upgraded unlike the other featuresets.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-08-12T18:50:31Z

Hello @jatinsu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci · 2025-08-12T18:51:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jatinsu
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-08-12T19:24:18Z

@jatinsu: This pull request references OKD-259 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

In response to this:

This PR was largely bult on the work done by @Prashanth684

This first pass only includes all featuregates which are default

For OKD clusters, this would be the "default" featureset

Allows for upgrades

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-08-12T22:36:39Z

@jatinsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp	`e8154b1`	link	false	`/test e2e-gcp`
ci/prow/okd-scos-e2e-aws-ovn	`e8154b1`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/verify-crd-schema	`e8154b1`	link	true	`/test verify-crd-schema`
ci/prow/integration	`e8154b1`	link	true	`/test integration`
ci/prow/e2e-aws-ovn-techpreview	`e8154b1`	link	true	`/test e2e-aws-ovn-techpreview`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-merge-robot · 2025-08-12T22:36:50Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoelSpeed · 2025-08-13T11:21:15Z

config/v1/types_feature.go

+	// OKD turns on features for OKD. Turning this feature set ON is supported for OKD clusters, but NOT for OpenShift clusters
+	// this feature set on CANNOT BE UNDONE for OKD clusters and when enabled on OpenShift clusters it PREVENTS UPGRADES.
+	OKD FeatureSet = "OKD"


How do we prevent this from being an option on OCP clusters?

What options do we have for including things in OCP but not OKD? Does OKD ship as a different cluster profile perhaps?

yes we need to do this. similar to the model that the installer and other repos follow, we can restrict it to be enabled only on OKD clusters.

Currently, you're going to generate an API that will be applied to OCP clusters, which means that in theory we have to either a) block this value from being set at admission time, b) prevent the option from even being included in the API schema

I would probably lean towards b, but that means creating separate payload manifests for OKD I believe 🤔

We also currently have no way to create differences like that in the tooling apart from feature gates, but, that isn't a long term thing, so we would need to provide other options

block this value from being set at admission time

can we do this in cluster config operator maybe? if the featureset being enabled is OKD and the image is not built for OKD (through the method above), we reject it?

But also - the other angle here: Why do we want to prevent it from being turned on for OCP? It will always be a subset of techpreviewNoUpgrade, the only difference being that it will be upgradeable only on OKD clusters (this we can control through CCO as done here). This will mean from an OCP perspective, it will be just another featureset. There are no OKD specific features (nor do i see any in the future).

can we do this in cluster config operator maybe?

We used to validate the feature gate transitions and values in the API server directly, but this was removed in favour of CEL, see https://github.com/openshift/kubernetes/pull/1944/files

Config operator doesn't have any admission time validation ability

Why do we want to prevent it from being turned on for OCP?

I don't think we want an extra feature set in OCP. We have TPNU, we have DPNU, we have CNU.

Enabling an OKD feature sat that isn't OKDNU in OCP sends the wrong signal IMO. All of our features sets that have existed in OCP have either been upgradable, or have had NoUpgrade in the name.

The OKD set can be achieved as a version of CNU if a customer so desired.

JoelSpeed · 2025-08-13T11:28:34Z

features/features.go

@@ -40,7 +40,7 @@ var (
 					reportProblemsToJiraComponent("Management Console").
 					contactPerson("jhadvig").
 					productScope(ocpSpecific).
-					enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
+					enableIn(configv1.Default, configv1.OKD, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).


Is there ever a reason we would want to promote a feature to Default and not have it also in the OKD featureset? If there isn't, we should either make it so that the OKD featureset inherits from the Default feature set, or, add some sort of test that will flag when something is promoted without OKD being added

If there isn't, we should either make it so that the OKD featureset inherits from the Default feature set, or, add some sort of test that will flag when something is promoted without OKD being added

agree, I wanted to connect with you about that @JoelSpeed . outside of code reviewing and enforcing that it be added to the OKD featureset as well - I didn't think there were other methods. How do we inherit from the default featureset ?

How do we inherit from the default featureset

It would need code changes to the generation of the featureset specific manifests, that's something we could do, but it hasn't been done before

How certain are we that every OCP feature will always land in OKD?

How certain are we that every OCP feature will always land in OKD?

100% i would say. Every feature in the default featureset is also in OKD by default.

jatinsu added 2 commits August 12, 2025 14:33

Introduce new OKD featureset and enable all default featuregates

75f8fdb

ran make update

e8154b1

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 12, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2025

openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 12, 2025

openshift-ci bot requested review from cheesesashimi and JoelSpeed August 12, 2025 18:51

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2025

JoelSpeed reviewed Aug 13, 2025

View reviewed changes

WIP: OKD-259: Support an "OKD" featureset to be enabled by default on OKD clusters #2451

Are you sure you want to change the base?

WIP: OKD-259: Support an "OKD" featureset to be enabled by default on OKD clusters #2451

Uh oh!

Conversation

jatinsu commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 12, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Aug 12, 2025

Uh oh!

openshift-ci bot commented Aug 12, 2025

Uh oh!

openshift-ci-robot commented Aug 12, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Aug 12, 2025

Uh oh!

openshift-merge-robot commented Aug 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jatinsu commented Aug 12, 2025 •

edited

Loading

openshift-ci-robot commented Aug 12, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 12, 2025 •

edited by openshift-ci bot

Loading