[release-4.19] CNTRLPLANE-1609: Add feature gates for StreamingCollectionEncoding

[rh-roman]

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Adding a feature gate to allow customers to enable API streaming features.

[openshift-ci]

Hello @rh-roman! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

Hi @rh-roman. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@rh-roman: This pull request references OCPSTRAT-2467 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.21" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[benluddy]

/retitle [release-4.19] OCPSTRAT-2467: Add feature gate for StreamingCollectionEncoding

[benluddy]

/ok-to-test

[openshift-ci]

@benluddy: This PR was included in a payload test run from openshift/kubernetes#2478
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/28fb66a0-9fca-11f0-9331-8f7b43dad041-0

[JoelSpeed]

@rh-roman What's the motivation behind this PR? There's no description nor link to an appropriate jira card?

[kevinrizza]

@JoelSpeed We have been having a discussion about https://issues.redhat.com/browse/OCPSTRAT-2467, where the relevant reasoning is written in the description. We are starting by pulling all of these changes behind tech preview, which is what this PR is for. If it helps, we can discuss offline in more detail, but there's some significant asks from the business especially from HCM to pick this feature back to help with performance related to large LIST requests in managed clusters

[JoelSpeed]

@kevinrizza I've already been filled on on the strat, didn't make the connection that this PR was relevant/related to it.

Are we likely to be creating appropriate bugs to link to PRs for each of the required backports? This change looks fine, but there's admin to do

From a hygiene and future archeology perspective, I would expect the PR description to be included with appropriate detail please

[openshift-ci-robot]

@rh-roman: This pull request references OCPSTRAT-2467 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.21" instead.

In response to this:

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Adding a feature gate to allow customers to enable API streaming features.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[benluddy]

/retitle [release-4.19] CNTRLPLANE-1609: Add feature gates for StreamingCollectionEncoding

[openshift-ci-robot]

@rh-roman: This pull request references CNTRLPLANE-1609 which is a valid jira issue.

In response to this:

Due to significant customer need for performance improvements related to API server pressure from large LIST requests, backporting the API streaming features that have been introduced in 1.33/1.34 related to kubernetes/enhancements#3157

Adding a feature gate to allow customers to enable API streaming features.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/lgtm
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rh-roman]

/verified

[openshift-ci-robot]

@rh-roman: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

In response to this:

/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/label jira/valid-bug

There's nothing to be done in 4.20 as these features are enabled by default, lets skip the toil of making the bug bot happy here

[rh-roman]

/verified by @rh-roman

[openshift-ci-robot]

@rh-roman: This PR has been marked as verified by @rh-roman.

In response to this:

/verified by @rh-roman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.