CONSOLE-5118: Improve AI assessment prompts - #16880
Conversation
|
@fao89: This pull request references CONSOLE-5118 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
WalkthroughCluster update prompts now standardize TL;DR Data Completeness confidence wording and terminal fields. Cluster update alerts use a dedicated AI info icon, split irreversible-update titles from body messages, and update English localization entries. ChangesCluster update prompt contracts
Irreversible update alerts
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
component/core
|
/verified by @fao89 |
openshift-ci-robot
added
the
verified
|
@fao89: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@fao89: GitHub didn't allow me to request PR reviews from the following users: rh-joshbeverly. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| title={t( | ||
| 'public~Cluster updates are irreversible. After an update begins, it cannot be rolled back to the previous version. Verify your cluster is ready before you proceed.', | ||
| )} | ||
| title={t('public~Cluster updates are irreversible')} |
There was a problem hiding this comment.
nit: useTranslation('public') already sets the default namespace of the t function to "public". No need to specify the namespace again in the strings
…y notice Standardize TL;DR sections across all prompt templates by moving Data Completeness near the top, simplifying its format, and enforcing terminal fields (Recommendation/Next Steps). Update the AI Assessment card icon and split the irreversibility warning into a title and body for better readability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>
cd6e6cd to
209120f
Compare
openshift-ci-robot
removed
the
verified
|
@fao89: This pull request references CONSOLE-5118 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @fao89 |
openshift-ci-robot
added
the
verified
|
@fao89: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@frontend/packages/console-shared/src/components/cluster-updates/prompts/precheck-no-updates.ts`:
- Line 144: Standardize the terminal action contract in both prompt templates:
in
frontend/packages/console-shared/src/components/cluster-updates/prompts/precheck-no-updates.ts
at lines 144-144, add a final Recommendation or Next Steps field after Next
Review; in
frontend/packages/console-shared/src/components/cluster-updates/prompts/progress.ts
at lines 211-211, add the same field after Action Required, or explicitly
document that prompt as an exemption.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0f0d4eba-367d-483d-ab3b-73ae413ce96f
📒 Files selected for processing (8)
frontend/packages/console-shared/src/components/cluster-updates/prompts/precheck-no-updates.tsfrontend/packages/console-shared/src/components/cluster-updates/prompts/precheck-specific.tsfrontend/packages/console-shared/src/components/cluster-updates/prompts/precheck.tsfrontend/packages/console-shared/src/components/cluster-updates/prompts/progress.tsfrontend/packages/console-shared/src/components/cluster-updates/prompts/troubleshoot.tsfrontend/public/components/cluster-settings/cluster-settings.tsxfrontend/public/components/modals/cluster-update-modal.tsxfrontend/public/locales/en/public.json
🚧 Files skipped from review as they are similar to previous changes (1)
- frontend/public/components/cluster-settings/cluster-settings.tsx
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest-required |
|
@fao89: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Standardize TL;DR sections across all prompt templates by moving Data Completeness near the top, simplifying its format, and enforcing terminal fields (Recommendation/Next Steps). Update the AI Assessment card icon and split the irreversibility warning into a title and body for better readability.
Analysis / Root cause:
Solution description:
Screenshots / screen recording:
Test setup:
Test cases:
Browser conformance:
Additional info:
Reviewers and assignees:
Summary by CodeRabbit