Skip to content

NO-JIRA: UPSTREAM: 133682: Increase port-forward broken connection detection client timeout #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

NO-JIRA: UPSTREAM: 133682: Increase port-forward broken connection detection client timeout #2428

merged 1 commit into from
Sep 11, 2025

Conversation

ardaguclu
Copy link
Member

In order to fix the red cell in oc in component readiness dashboard (link), this PR carries the upstream timeout bump in here.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Aug 27, 2025
@openshift-ci-robot
Copy link

@ardaguclu: This pull request explicitly references no jira issue.

In response to this:

In order to fix the red cell in oc in component readiness dashboard (link), this PR carries the upstream timeout bump in here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@ardaguclu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from deads2k and jerpeter1 August 27, 2025 05:57
@ardaguclu
Copy link
Member Author

/hold
upstream PR has updated.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2025
@ardaguclu ardaguclu force-pushed the increase-pf-timeout branch from c632ae2 to 5404a7d Compare August 28, 2025 06:20
@openshift-ci-robot
Copy link

@ardaguclu: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ardaguclu ardaguclu force-pushed the increase-pf-timeout branch from 5404a7d to b991326 Compare August 29, 2025 05:23
@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Aug 29, 2025
@openshift-ci-robot
Copy link

@ardaguclu: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ardaguclu
Copy link
Member Author

/hold cancel
/cc @bertinatto
could you please take a look at this carry, when you have a chance?.

@openshift-ci openshift-ci bot requested a review from bertinatto August 29, 2025 05:25
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2025
@ardaguclu
Copy link
Member Author

/retest-required
/label acknowledge-critical-fixes-only
this carry can not make the test worst but it can fix it

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Aug 29, 2025
@bertinatto
Copy link
Member

/lgtm

@bertinatto
Copy link
Member

/retest-required

bertinatto
bertinatto reviewed Sep 1, 2025
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a237dcb and 2 for PR HEAD b991326 in total

@ardaguclu
Copy link
Member Author

/retest-required

1 similar comment
@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

I don't know about the requirement of verified label
/label verified
?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 3, 2025

@ardaguclu: The label(s) /label verified cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, backports/unvalidated-commits, backports/validated-commits, bugzilla/invalid-bug, bugzilla/valid-bug, cherry-pick-approved, jira/invalid-bug, jira/valid-bug, jira/valid-reference, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

I don't know about the requirement of verified label
/label verified
?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

/verified by @ardaguclu

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 9, 2025
@openshift-ci-robot
Copy link

@ardaguclu: This PR has been marked as verified by @ardaguclu.

In response to this:

/verified by @ardaguclu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6efb6a9 and 2 for PR HEAD b991326 in total

@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6efb6a9 and 2 for PR HEAD b991326 in total

@ardaguclu
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6efb6a9 and 2 for PR HEAD b991326 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6efb6a9 and 2 for PR HEAD b991326 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6efb6a9 and 2 for PR HEAD b991326 in total

@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6efb6a9 and 2 for PR HEAD b991326 in total

@ardaguclu
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6efb6a9 and 2 for PR HEAD b991326 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 11, 2025

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fbd7a06 into openshift:master Sep 11, 2025
25 checks passed
@ardaguclu ardaguclu deleted the increase-pf-timeout branch September 11, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@deads2k deads2k Awaiting requested review from deads2k

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees

@bertinatto bertinatto

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ardaguclu @openshift-ci-robot @bertinatto