4.16: OCPBUGS-60872: UPSTREAM: 127757: scheduler: Improve CSILimits plugin accuracy by using VolumeAttachments

[jsafrane]

Fix calculation of CSI volume limits in the scheduler. Make sure VolumeAttachments that could be being detached are counted too.

Backport of #2283 to 4.16.

[openshift-ci-robot]

@jsafrane: This pull request references Jira Issue OCPBUGS-60872, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-60998 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix calculation of CSI volume limits in the scheduler. Make sure VolumeAttachments that could be being detached are counted too.

Backport of #2283 to 4.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jsafrane: the contents of this pull request could be automatically validated.

The following commits are valid:

• 757c395|UPSTREAM: 127757: scheduler: Improve CSILimits plugin accuracy by using VolumeAttachments: the upstream PR kubernetes/kubernetes#127757 has merged

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/k8s-e2e-aws-ovn-serial	757c395	link	false	/test k8s-e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[duanwei33]

/jira refresh

[openshift-ci-robot]

@duanwei33: This pull request references Jira Issue OCPBUGS-60872, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.z) matches configured target version for branch (4.16.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-60998 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-60998 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[duanwei33]

Per-merge verification passed with the open PR

$ oc version
Client Version: 4.19.0-0.nightly-2025-02-09-122440
Kustomize Version: v5.4.2
Server Version: 4.16.0-0-2025-09-04-022527-test-ci-ln-lqn13gb-latest
Kubernetes Version: v1.29.0-rc.1.4210+4a992046d8e504-dirty

The scheduler leaves the Pod Pending following the Steps

[duanwei33]

/verified by @duanwei33

[openshift-ci-robot]

@duanwei33: This PR has been marked as verified by @duanwei33.

In response to this:

/verified by @duanwei33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[duanwei33]

/retest-required