adds minimal support for attaching detected ACM clusters #864
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Thanks @thoraxe!
Generally looks great - just a couple of small comments
I also see there are some lint errors. If you run npm run i18n && npm run lint-fix it will probably fix everything automatically (some lint issues need manual fixing, but ~90% can be automatically fixed)
| @@ -335,6 +392,10 @@ const AttachMenu: React.FC = () => { | |||
| <SelectOption value={AttachmentTypes.YAML}> | |||
| <FileCodeIcon /> {t('Alert')} {isLoading && <Spinner size="md" />} | |||
| </SelectOption> | |||
| ) : kind === 'cluster.open-cluster-management.io~v1~ManagedCluster' ? ( | |||
| <SelectOption value={AttachmentTypes.YAML}> | |||
| <TaskIcon /> {t('Attach cluster info')} | |||
There was a problem hiding this comment.
| <TaskIcon /> {t('Attach cluster info')} | |
| <TaskIcon /> {t('Attach cluster info')} {isLoading && <Spinner size="md" />} |
(not tested)
src/hooks/useLocationContext.ts
Outdated
| const modelKey = Object.keys(models).find((k) => models[k].plural === key); | ||
| if (modelKey) { | ||
| const model = models[modelKey]; | ||
| if (model && model.kind !== 'Secret') { | ||
| setKind(key); | ||
| setName(urlMatches[1]); | ||
| setNamespace(undefined); | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
This looks redundant since we are only searching for one specific key, which I think should be a key of models, not a plural.
lint errors fixed via 88ef4e9 |
|
Thanks @thoraxe. Could you please squash the commits too? |
|
/retest |
|
This failure is extremely weird. There's no logs for the tests. It's like the tests refused to start for 2 hours... |
I can try |
|
force pushed squashed |
|
@thoraxe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.