Added integration.go file #1331
Conversation
openshift-ci
bot
added
the
size/M
|
/assign @jeff-roche @kasturinarra |
mmakwana30
force-pushed
the
integration
branch
from
757a01c to
dab3bb9
Compare
| @@ -0,0 +1,53 @@ | |||
| package main | |||
There was a problem hiding this comment.
I would suggest creating a new file called main.go inside cmd/integration-tests/main.go with package main.
There was a problem hiding this comment.
The file name doesn't particularly matter since we can feed it directly to the go build command. I believe best practice is to only have 1 main.go in a repo which we already have in the cmd folder so I think leaving it as integration here is fine
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmakwana30 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| "fmt" | ||
| "os" | ||
|
|
||
| et "github.com/openshift-eng/openshift-tests-extension/pkg/extension/extensiontests" |
There was a problem hiding this comment.
I see we are not using the et anywhere, this can be removed.
There was a problem hiding this comment.
I would just comment it out for now so that we don't end up with compile errors. We will want it down the road though
|
|
||
| // all test cases | ||
| ext.AddSuite(e.Suite{ | ||
| Name: "openshift/lvm-operator/test", |
There was a problem hiding this comment.
Better naming would be openshift/lvm-operator/integration or openshift/lvm-operator/integration-tests ?
There was a problem hiding this comment.
I like openshift/lvm-operator/integration
| registry := e.NewRegistry() | ||
|
|
||
| // You can declare multiple extensions, but most people will probably only need to create one. | ||
| ext := e.NewExtension("openshift", "payload", "lvm-operator") |
There was a problem hiding this comment.
I am not very sure about the payload here, but i will let jeff comment more on that as i am not very sure what should we be selecting.
There was a problem hiding this comment.
I didn't find any validation in the source so we will go with payload for now and see if it works
|
@mmakwana30: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Epic: https://issues.redhat.com/browse/OCPEDGE-2013
Jira : https://issues.redhat.com/browse/OCPEDGE-2014