MG-247: collect imagedigestmirrorsets and imagetagmirrorset resources

[simonstumpf]

This PR aims to include ImageDigestMirrorSet and ImageTagMirrorSet resources which are currently not included in the data collection.

Using ImageContentSourcePolicy is a deprecated feature which is being replaced with ImageDigestMirrorSet and ImageTagMirrorSet

[openshift-ci-robot]

@simonstumpf: This pull request references MG-247 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR aims to include ImageDigestMirrorSet and ImageTagMirrorSet resources which are currently not included in the data collection.

Using ImageContentSourcePolicy is a deprecated feature which is being replace with ImageDigestMirrorSet and ImageTagMirrorSet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3ca68036-3558-436e-81f4-c663f2a1c8e8

📥 Commits

Reviewing files that changed from the base of the PR and between 84268cd and b69e1fa.

📒 Files selected for processing (1)

• collection-scripts/gather

---

Walkthrough

Expanded the "Image-source Resources" list used by the gather script: added imagedigestmirrorsets.config.openshift.io and imagetagmirrorsets.config.openshift.io to the resources passed to oc adm inspect. No control flow or namespace-scoping changes.

Changes

Cohort / File(s)	Summary
Image-source Resources Expansion collection-scripts/gather	Added two OpenShift image mirror resource types to the comma-separated resource list passed to oc adm inspect: imagedigestmirrorsets.config.openshift.io and imagetagmirrorsets.config.openshift.io.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simonstumpf
Once this PR has been reviewed and has the lgtm label, please assign sferich888 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• collection-scripts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @simonstumpf. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@collection-scripts/gather`:
- Line 44: The group_resources array entry contains a typo: "imagetagmirrorset"
(singular) should be the plural "imagetagmirrorsets", causing ImageTagMirrorSet
resources to be skipped; update the array addition (the group_resources+=(...)
line) to include imagetagmirrorsets.config.openshift.io instead of
imagetagmirrorset.config.openshift.io so the script correctly collects those
resources.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1b1000be-603b-411f-ade8-070f777e252e

📥 Commits

Reviewing files that changed from the base of the PR and between eb617ed and 84268cd.

📒 Files selected for processing (1)

• collection-scripts/gather

[openshift-ci-robot]

@simonstumpf: This pull request references MG-247 which is a valid jira issue.

Details

In response to this:

This PR aims to include ImageDigestMirrorSet and ImageTagMirrorSet resources which are currently not included in the data collection.

Using ImageContentSourcePolicy is a deprecated feature which is being replaced with ImageDigestMirrorSet and ImageTagMirrorSet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.