[release-4.20] OCPBUGS-111100: Use ServiceRoot.Vendor for detect_vendor() instead of System.Manufacturer

[hroyrh]

Some systems like Dell GB200 NVL servers use AMI MegaRAC BMCs rebranded under Dell. System.Manufacturer returns "Dell Inc." (the chassis OEM), but the BMC firmware is actually AMI. This causes detect_vendor() to misidentify the vendor, triggering the wrong firmware version check and missing AMI-specific code paths.

Prefer the Redfish ServiceRoot Vendor field which correctly identifies the BMC firmware vendor. Fall back to System.Manufacturer when ServiceRoot.Vendor is not available.

Closes-Bug: #2143027

Change-Id: Ib988ed6b84848e9b479f40255e2175f70751d61f

(cherry picked from commit 84ff824) (cherry picked from commit bf6187b)

[openshift-ci-robot]

@hroyrh: This pull request references Jira Issue OCPBUGS-111100, which is invalid:

• expected dependent Jira Issue OCPBUGS-111098 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Some systems like Dell GB200 NVL servers use AMI MegaRAC BMCs rebranded under Dell. System.Manufacturer returns "Dell Inc." (the chassis OEM), but the BMC firmware is actually AMI. This causes detect_vendor() to misidentify the vendor, triggering the wrong firmware version check and missing AMI-specific code paths.

Prefer the Redfish ServiceRoot Vendor field which correctly identifies the BMC firmware vendor. Fall back to System.Manufacturer when ServiceRoot.Vendor is not available.

Closes-Bug: #2143027

Change-Id: Ib988ed6b84848e9b479f40255e2175f70751d61f

(cherry picked from commit 84ff824) (cherry picked from commit bf6187b)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@hroyrh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hroyrh]

/jira refresh

[openshift-ci-robot]

@hroyrh: This pull request references Jira Issue OCPBUGS-111100, which is invalid:

• expected dependent Jira Issue OCPBUGS-111098 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dtantsur]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, hroyrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment