OCPBUGS-61063: test/extended/cli/adm_upgrade/recommend: Enable precheck and accept #30113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
These will probably not pass without more work, but checking to see how far away we are.
|
Job Failure Risk Analysis for sha: fcebaa6
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
2 times, most recently
from
ae9e67d to
b18aac0
Compare
openshift-ci
bot
removed
the
approved
Avoid [1]:
Error running oc --namespace=e2e-oc-adm-upgrade-recommend-393 --kubeconfig=/tmp/kubeconfig-1102618529 adm upgrade recommend --version 4.21.0:
StdOut>
Failed to check for at least some preconditions: failed to get alerts from Thanos: no token is currently in use for this session
Upstream update service: http://172.30.88.84:8000/graph
...
by creating a service account so we can use token-based access for the
alert-retrieval.
[1]: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30113/pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2/1955777594481709056
|
Job Failure Risk Analysis for sha: b18aac0
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: b18aac0
New tests seen in this PR at sha: b18aac0
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
34ec4d1 to
2a74ae2
Compare
|
Job Failure Risk Analysis for sha: 2a74ae2
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
2a74ae2 to
8924956
Compare
|
Job Failure Risk Analysis for sha: 8924956
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
2 times, most recently
from
931699e to
d7501ee
Compare
|
Job Failure Risk Analysis for sha: d7501ee
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: d7501ee
New tests seen in this PR at sha: d7501ee
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
2 times, most recently
from
3d796c1 to
6f8ca39
Compare
|
Job Failure Risk Analysis for sha: 6f8ca39
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
6f8ca39 to
4cbd5fe
Compare
|
Job Failure Risk Analysis for sha: 4cbd5fe
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 4cbd5fe
New tests seen in this PR at sha: 4cbd5fe
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
4cbd5fe to
b9b2c30
Compare
|
Job Failure Risk Analysis for sha: b9b2c30
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: b9b2c30
New tests seen in this PR at sha: b9b2c30
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
b9b2c30 to
ccb493b
Compare
|
Job Failure Risk Analysis for sha: ccb493b
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
ccb493b to
eefe2bb
Compare
|
Job Failure Risk Analysis for sha: eefe2bb
Showing 20 of 40 jobs analysis |
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
eefe2bb to
93f5c58
Compare
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
3 times, most recently
from
12c29c5 to
5c406e9
Compare
|
Job Failure Risk Analysis for sha: 5c406e9
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 5c406e9
New tests seen in this PR at sha: 5c406e9
|
|
openshift/oc#2083 should address the cert issue: /test e2e-aws-ovn-serial-2of2 |
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
5c406e9 to
5d9d9db
Compare
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 5d9d9db
New tests seen in this PR at sha: 5d9d9db
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
5d9d9db to
88c9905
Compare
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 88c9905
New tests seen in this PR at sha: 88c9905
|
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
3 times, most recently
from
1483aa0 to
7c7a3fa
Compare
Avoid [1]:
: [Serial][sig-cli] oc adm upgrade recommend When the update service has conditional recommendations runs successfully with an accepted conditional recommendation to the --version target [Suite:openshift/conformance/serial] 20s
{ fail [github.com/openshift/origin/test/extended/cli/adm_upgrade/recommend.go:225]: Unexpected error:
<*errors.errorString | 0xc008463cc0>:
expected:
Failed to check for at least some preconditions: failed to get alerts from Thanos: unable to get /api/v1/alerts from URI in the openshift-monitoring/thanos-querier Route: thanos-querier-openshift-monitoring.apps.ci-op-p9ttsvlv-173fd.XXXXXXXXXXXXXXXXXXXXXX->Get "https://thanos-querier-openshift-monitoring.apps.ci-op-p9ttsvlv-173fd.XXXXXXXXXXXXXXXXXXXXXX/api/v1/alerts": tls: failed to verify certificate: x509: certificate signed by unknown authority
by retrieving the default (self-signed) ingress certificate and
passing it to 'oc' via --certificate-authority and a temporary file.
The default ingress certificate knobs I'm using are documented in [2].
The router-certs-default fallback may not be documented, but is backed
by [3,4].
We need to keep trusting the Kube API server though, and while I'm not
clear on the mechanism it uses to pick its external API server
certificate, iterating over all the TLS secrets in the Kube API server
namespace and aggregating seems like it should pick up the one we
need.
[1]: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/30113/pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2/1956090254670696448
[2]: https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress
[3]: https://github.com/openshift/cluster-ingress-operator/blob/afb2160975399f4249d9d100641ce32a33c262f1/pkg/operator/controller/certificate/default_cert.go#L76-L83
[4]: https://github.com/openshift/cluster-ingress-operator/blob/afb2160975399f4249d9d100641ce32a33c262f1/pkg/operator/controller/names.go#L152-L159
[5]: https://kubernetes.io/docs/concepts/configuration/secret/#tls-secrets
wking
force-pushed
the
test-oc-adm-upgrade-recommend-with-precheck-and-accept
branch
from
7c7a3fa to
0c633d8
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
I think mentioning us using --accept makes for a more clear name, but the generated annotation file has a different approver set, so I'm deferring that until we have more time to loop those folks in.
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 0c633d8
|
wking
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@wking: This pull request references Jira Issue OCPBUGS-61062, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wking
changed the title
openshift-ci-robot
added
jira/invalid-bug
|
@wking: This pull request references Jira Issue OCPBUGS-61063, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@wking: This pull request references Jira Issue OCPBUGS-61063, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will probably not pass without more work, but checking to see how far away we are.