-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Revert "Merge pull request #30134 from Amarthya-v/fix-endpoint-admission-namespace-creation" #30362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.20
Are you sure you want to change the base?
Revert "Merge pull request #30134 from Amarthya-v/fix-endpoint-admission-namespace-creation" #30362
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Amarthya-v The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What's more disruptive about the current approach? |
The webhook was blocking valid customer operations, not just test scenarios. |
I was asking about the change in the PR that is being reverted. I wan't to understand what issue did it introduce or are we just removing it because it is no longer needed. |
Since the webhook restriction is being removed, the test workaround is unnecessary. It's no longer needed |
|
@Amarthya-v: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This reverts commit cc8ae10, reversing changes made to 0dfa8e5.
The MCVW that was blocking namespace operations for cluster-admins is being reverted by the SRE team as it's more disruptive than intended. Since the webhook restriction is being removed, this test fix is no longer needed.
Resolves: SREP-2020