Skip to content

Conversation

Amarthya-v
Copy link

@Amarthya-v Amarthya-v commented Oct 9, 2025

This reverts commit cc8ae10, reversing changes made to 0dfa8e5.

The MCVW that was blocking namespace operations for cluster-admins is being reverted by the SRE team as it's more disruptive than intended. Since the webhook restriction is being removed, this test fix is no longer needed.

Resolves: SREP-2020

…nt-admission-namespace-creation"

This reverts commit cc8ae10, reversing
changes made to 0dfa8e5.
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Amarthya-v
Once this PR has been reviewed and has the lgtm label, please assign pliurh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 9, 2025

This reverts commit cc8ae10, reversing changes made to 0dfa8e5.

The MCVW that was blocking namespace operations for cluster-admins is being reverted by the SRE team as it's more disruptive than intended. Since the webhook restriction is being removed, this test fix is no longer needed.

Resolves: SREP-2020

What's more disruptive about the current approach?

@Amarthya-v
Copy link
Author

This reverts commit cc8ae10, reversing changes made to 0dfa8e5.
The MCVW that was blocking namespace operations for cluster-admins is being reverted by the SRE team as it's more disruptive than intended. Since the webhook restriction is being removed, this test fix is no longer needed.
Resolves: SREP-2020

What's more disruptive about the current approach?

The webhook was blocking valid customer operations, not just test scenarios.
Customers couldn’t update the logging stack, oc diff returned 403s, and RHOAI installs failed in staging.
Restrictions on cluster-admin access were too broad.
so SRE is reverting the change and planning a more targeted fix to maintain protection without blocking legitimate workflows.

@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 9, 2025

This reverts commit cc8ae10, reversing changes made to 0dfa8e5.
The MCVW that was blocking namespace operations for cluster-admins is being reverted by the SRE team as it's more disruptive than intended. Since the webhook restriction is being removed, this test fix is no longer needed.
Resolves: SREP-2020

What's more disruptive about the current approach?

The webhook was blocking valid customer operations, not just test scenarios. Customers couldn’t update the logging stack, oc diff returned 403s, and RHOAI installs failed in staging. Restrictions on cluster-admin access were too broad. so SRE is reverting the change and planning a more targeted fix to maintain protection without blocking legitimate workflows.

I was asking about the change in the PR that is being reverted. I wan't to understand what issue did it introduce or are we just removing it because it is no longer needed.

@Amarthya-v
Copy link
Author

This reverts commit cc8ae10, reversing changes made to 0dfa8e5.
The MCVW that was blocking namespace operations for cluster-admins is being reverted by the SRE team as it's more disruptive than intended. Since the webhook restriction is being removed, this test fix is no longer needed.
Resolves: SREP-2020

What's more disruptive about the current approach?

The webhook was blocking valid customer operations, not just test scenarios. Customers couldn’t update the logging stack, oc diff returned 403s, and RHOAI installs failed in staging. Restrictions on cluster-admin access were too broad. so SRE is reverting the change and planning a more targeted fix to maintain protection without blocking legitimate workflows.

I was asking about the change in the PR that is being reverted. I wan't to understand what issue did it introduce or are we just removing it because it is no longer needed.

Since the webhook restriction is being removed, the test workaround is unnecessary. It's no longer needed

Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@Amarthya-v: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 647aa4b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-upi 647aa4b link true /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants