-
Notifications
You must be signed in to change notification settings - Fork 4.8k
OCPBUGS-62987: Skip idling service with RC test on TechPreview clusters #30375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@alebedev87: This pull request references Jira Issue OCPBUGS-62987, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@alebedev87: This pull request references Jira Issue OCPBUGS-62987, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-techpreview |
@alebedev87: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7935e2b0-a850-11f0-97c3-1e923ba4ab7f-0 |
ecf5c91
to
3c33bce
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, sosiouxme The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-techpreview |
@alebedev87: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e70b2fd0-a877-11f0-8ec2-e54b4d6e79e3-0 |
The payload job successfully skipped the idling service for RC test:
|
/retest |
g.BeforeEach(func() { | ||
if exutil.IsTechPreviewNoUpgrade(context.Background(), oc.AdminConfigClient()) { | ||
g.Skip("skipping, this test is only supported on Default featureset until https://issues.redhat.com/browse/NE-1984 is implemented") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why the "should idle the service and DeploymentConfig properly" test doesn't need a skip? It also defines a route in its fixture (idling-echo-server.yaml
) and uses checkSingleIdle
to verify that the application remains idle, so I would expect OCPBUGS-49908 to affect it as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so I would expect OCPBUGS-49908 to affect it as well.
Yes, I expect too but I don't recall seeing it failed. That's why https://issues.redhat.com/browse/OCPBUGS-49908 mentions explicitly only the RC case. https://issues.redhat.com//browse/OCPBUGS-62987 also mentions only the RC case. So I prefer to do things gradually. If the DC case will pop up in the similar way, I'll disable it too. However until it's not, this may be a good corner case to dig deeper during https://issues.redhat.com/browse/NE-1984 implementation.
/retest-required |
/test go-verify-deps |
1 similar comment
/test go-verify-deps |
This commit skips the test "Idling with a single service and ReplicationController should idle the service and ReplicationController properly" when the TechPreviewNoUpgrade feature set is enabled. The router's Dynamic Configuration Manager (DCM) currently lacks full support for handling idled services, which causes this test to flake. The support gap will be addressed in https://issues.redhat.com/browse/NE-1984.
3c33bce
to
233f138
Compare
Rebased from |
@alebedev87: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR skips the test
Idling with a single service and ReplicationController should idle the service and ReplicationController properly
when the TechPreviewNoUpgrade feature set is enabled.The router's Dynamic Configuration Manager (DCM) currently lacks full support for handling idled services, which causes this test to flake.
The support gap will be addressed in https://issues.redhat.com/browse/NE-1984.