-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CNTRLPLANE-1662: Migrate OCP-32383 to upstream #30378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: cbb5903
New tests seen in this PR at sha: cbb5903
|
51a8e1b
to
0e2b3c0
Compare
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 0e2b3c0
|
/retest-required |
These names clearly indicate what the test is verifying.
|
if isHyperShift { | ||
g.Skip("HyperShift does not support this test") | ||
} | ||
checkItems := []struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider oauth-apiserver
Checkpoints Advice Simply checking for privileged: true is good, but for core platform components, you can add more specific and robust checkpoints to ensure they are configured correctly and securely.
|
oc := exutil.NewCLIWithPodSecurityLevel("e2e-qe-apiserver", admissionapi.LevelPrivileged) | ||
|
||
// author: [email protected] | ||
g.It("Init container setup should have the proper securityContext-[OCP-32383]-bug 1793694", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g.It
(The Test Case Name):-
Current: "Init container setup should have the proper securityContext-[OCP-32383]-bug 1793694"
-
Problem: It's too specific ("Init container"), contains internal bug trackers (OCP-32383), and is verbose.
-
Suggestion: The test case should state the expected outcome clearly and concisely.
g.It("should run core API server pods with a privileged security context", func() {
Reasoning:- This is a clear, readable statement of the test's purpose.
- It removes all internal references, making it suitable for the public origin repository.
- Specifics about which pods and containers are checked can be detailed inside the test using g.By() blocks.
-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make title clean, add one comment to descirbe CaseID and bug ID.
f6fe496
to
f91646d
Compare
admissionapi "k8s.io/pod-security-admission/api" | ||
) | ||
|
||
var _ = g.Describe("[sig-api-machinery][E2E-QE-APIServer]", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming of your test blocks is critical for communicating intent to the open-source community. Internal references should be removed.
g.Describe
(The Suite Name):-
Current: [sig-api-machinery][E2E-QE-APIServer]
-
Problem: E2E-QE-APIServer is an internal-sounding name that doesn't describe the feature under test.
-
Suggestion: The suite should describe the broad feature area. Since this test verifies the security posture of core control plane components, a better name would be:
var _ = g.Describe("[sig-auth][Feature:ControlPlaneSecurity]", func() {
Reasoning:- [sig-auth] is appropriate because securityContext and privileged pods are a core security and authorization concern.
- [Feature:ControlPlaneSecurity] clearly states that you are testing the security configuration of the control plane itself, not user workloads.
-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your final Describe line would look like this:
var _ = g.Describe("[sig-auth][Feature:ControlPlaneSecurity][Suite:openshift/conformance/parallel]", func() {
@gangwgr: This pull request references CNTRLPLANE-1662 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f91646d
to
0e4d7b0
Compare
0e4d7b0
to
8334eeb
Compare
@wangke19 Updated feedbacks
|
We check test result from CI jobs, local test is for debugging. Waiting for CI jobs. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gangwgr, stbenjam, wangke19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/verified by e2e jobs |
@wangke19: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
1 similar comment
/retest-required |
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 8334eeb
New tests seen in this PR at sha: 8334eeb
|
/test go-verify-deps |
/cc |
@gangwgr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Test verifies:
Addresses: OCP-32383
Related: bug 1793694