Skip to content

OCPBUGS-62875: images: test that creating an imagestream with --dry-run does not actually create the object #30403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-62875: images: test that creating an imagestream with --dry-run does not actually create the object #30403

wants to merge 1 commit into from
+24 −0

Conversation

liouk
Copy link
Member

@liouk liouk commented Oct 21, 2025 •
edited
Loading

This test will fail without openshift/oc#2117 and must not be merged before the fix.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 21, 2025
@openshift-ci-robot
Copy link

@liouk: This pull request references Jira Issue OCPBUGS-62875, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This test will fail without openshift/oc#2117.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ardaguclu
ardaguclu reviewed Oct 21, 2025
View reviewed changes
Copy link
Member

@ardaguclu ardaguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dropped a comment. Other than that looks good to me.
cc: @wangke19

test/extended/images/dryrun.go Outdated
o.Expect(err).NotTo(o.HaveOccurred())

// wait for 30s to make sure we'll not miss any resource created accidentally
err = wait.PollUntilContextTimeout(context.Background(), 1*time.Second, 30*time.Second, true, func(ctx context.Context) (bool, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guarantees that test will return after 30 seconds. Maybe it is better to return just after 10 seconds.

@liouk liouk mentioned this pull request Oct 21, 2025
Merged
@liouk liouk force-pushed the fix-oc-create-dryrun branch from a7639ca to 7872e88 Compare October 21, 2025 11:03
@ardaguclu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ardaguclu, liouk
Once this PR has been reviewed and has the lgtm label, please assign flavianmissi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

@liouk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 7872e88 link false /test okd-scos-e2e-aws-ovn
ci/prow/go-verify-deps 7872e88 link true /test go-verify-deps
ci/prow/e2e-vsphere-ovn-upi 7872e88 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-gcp-ovn 7872e88 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-image-registry 7872e88 link true /test e2e-aws-ovn-image-registry
ci/prow/e2e-vsphere-ovn 7872e88 link true /test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 7872e88 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-microshift-serial 7872e88 link false /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-fips 7872e88 link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-microshift 7872e88 link false /test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Oct 21, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 7872e88

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips High - "[sig-imageregistry] Image --dry-run should not create resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-aws-ovn-image-registry High - "[sig-imageregistry] Image --dry-run should not create resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-gcp-ovn High - "[sig-imageregistry] Image --dry-run should not create resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 High - "[sig-imageregistry] Image --dry-run should not create resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-vsphere-ovn High - "[sig-imageregistry] Image --dry-run should not create resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[sig-imageregistry] Image --dry-run should not create resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit
pull-ci-openshift-origin-main-okd-scos-e2e-aws-ovn High - "[sig-imageregistry] Image --dry-run should not create resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit

New tests seen in this PR at sha: 7872e88

  • "[sig-imageregistry] Image --dry-run should not create resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 7, Pass: 0, Fail: 7, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangke19 wangke19 Awaiting requested review from wangke19

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

@sjenning sjenning Awaiting requested review from sjenning

1 more reviewer

@ardaguclu ardaguclu ardaguclu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ardaguclu ardaguclu

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liouk @openshift-ci-robot @ardaguclu