Skip to content

[release-4.17] OCPBUGS-58408: Fix: One Alertmanager Config failing blocks all others. (#6585) #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-58408: Fix: One Alertmanager Config failing blocks all others. (#6585) #336

wants to merge 1 commit into from

Conversation

slashpai
Copy link
Member

@slashpai slashpai commented Jul 7, 2025

manual cherry-pick of prometheus-operator@324ff7c

@codeknight03 @slashpai
Fix: One Alertmanager Config failing blocks all others. (prometheus-o…
f9bf385 
…perator#6585)

* validation: added api url validation for Slack and Discord to stop
hanging up the operator.

* updated the changes according to the requirment.

* Added secure validation for secret urls.

Added ValidateSecretURL to securely validate url without logging it.

* Added operator test cases for Secret Url validation.

* Update according to changes made in alertmanager for config.SecretURL

* fix(alertmanager): update error messages to follow standards.

(cherry picked from commit 324ff7c)
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 7, 2025
@openshift-ci-robot
Copy link

@slashpai: This pull request references Jira Issue OCPBUGS-58408, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-58408 to depend on a bug targeting a version in 4.18.0, 4.18.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

manual cherry-pick of prometheus-operator@324ff7c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@slashpai
Copy link
Member Author

slashpai commented Jul 7, 2025

Fixing tests

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 7, 2025

@slashpai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f9bf385 link false /test security
ci/prow/test-unit f9bf385 link true /test test-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machine424 machine424 Awaiting requested review from machine424

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slashpai @openshift-ci-robot @codeknight03