Skip to content

Fix GitHub Actions CI #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix GitHub Actions CI #472

wants to merge 1 commit into from

Conversation

@nspark
Copy link
Contributor

@nspark nspark commented Jun 25, 2021 •
edited
Loading

  • Updates to v2 for actions
  • Adds ca-certificates dependence (see ref)

@nspark
Copy link
Contributor Author

nspark commented Jun 25, 2021

Despite referenced comment, I'm not sure the addition of ca-certificates is necessary, since those dependencies get installed after the repository is checked out.

@nspark
Copy link
Contributor Author

nspark commented Jun 25, 2021

@davidozog I think this fixes the CI issues we were having

@jdinan Okay to merge?

@nspark
Copy link
Contributor Author

nspark commented Jun 25, 2021

Well, this is odd. #470 failed on the first commit but not the second. Both ran on checkout@v1. (The first commit failed during the checkout step.) Maybe failures are occasional with v1, but v2 is more robust? I don't think it's bad to update to v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nspark