Migrate ghmerge from using python to jq #192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
reviewed
Apr 15, 2024
t8m
approved these changes
May 10, 2024
t8m
approved these changes
May 20, 2024
|
@nhorman This needs rebase. |
jq is a nice handy tool to do json parsing, use it instead of python
|
done |
paulidale
approved these changes
Oct 1, 2025
paulidale
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
I'm not entirely convinced that this change is worthwhile. It's not saving much in terms of lines of code, it's introducing a third party dependency and it's moving the parsing out of python into a separate process. The benefit seems to be an improvement in a section of code that isn't oft modified and isn't that difficult to understand.
levitte
approved these changes
Oct 2, 2025
nhorman
added a commit
that referenced
this pull request
Oct 2, 2025
jq is a nice handy tool to do json parsing, use it instead of python Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from #192)
|
merged to master, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jq is a nice handy tool to do json parsing, use it instead of python