Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Doc updates #925

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Doc updates #925

merged 2 commits into from
Jun 7, 2024
+48 −26

Conversation

slagle
Copy link
Collaborator

@slagle slagle commented Jun 6, 2024

  • Update internal_api -> internalapi
  • Update container image urls

slagle added 2 commits June 6, 2024 15:37
@slagle
Update internal_api -> internalapi
8db8ea2 
The default networkconfig[1] created from infra-operator uses
internalapi when the names were made all lower case. When networks_lower
is generated in inventory.go, there is no conversion from internapapi to
internal_api, so the docs should use internalapi.

Signed-off-by: James Slagle <[email protected]>
@slagle
Update container image urls
a41f098 
Adds missing containers to the list and updates the default locations.
The downstream locations will need to be updated periodically.

Signed-off-by: James Slagle <[email protected]>
@openshift-ci openshift-ci bot requested review from igallagh-redhat and rabi June 6, 2024 21:26
@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
@fao89
Copy link
Collaborator

fao89 commented Jun 7, 2024

/retest-required

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slagle
Copy link
Collaborator Author

slagle commented Jun 7, 2024

/override dataplane-operator-build-deploy-kuttl

this doesnt need to pass kuttl tests

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

@slagle: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • dataplane-operator-build-deploy-kuttl

Only the following failed contexts/checkruns were expected:

  • ci/prow/dataplane-operator-build-deploy-kuttl
  • ci/prow/functional
  • ci/prow/images
  • ci/prow/precommit-check
  • pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl
  • pull-ci-openstack-k8s-operators-dataplane-operator-main-functional
  • pull-ci-openstack-k8s-operators-dataplane-operator-main-images
  • pull-ci-openstack-k8s-operators-dataplane-operator-main-precommit-check
  • rdoproject.org/github-check
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override dataplane-operator-build-deploy-kuttl

this doesnt need to pass kuttl tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@slagle
Copy link
Collaborator Author

slagle commented Jun 7, 2024

/override ci/prow/dataplane-operator-build-deploy-kuttl

this doesnt need to pass kuttl tests

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

@slagle: Overrode contexts on behalf of slagle: ci/prow/dataplane-operator-build-deploy-kuttl

In response to this:

/override ci/prow/dataplane-operator-build-deploy-kuttl

this doesnt need to pass kuttl tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b507e39 into openstack-k8s-operators:main Jun 7, 2024
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fao89 fao89 fao89 approved these changes

@igallagh-redhat igallagh-redhat Awaiting requested review from igallagh-redhat

@rabi rabi Awaiting requested review from rabi

Assignees

@fao89 fao89

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slagle @fao89