Update nova-operator to gophercloud v2 #1025
Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bf41be6ed69c459abfedba2e3a5cd94f ❌ openstack-meta-content-provider FAILURE in 20m 47s |
|
needs #1029 first |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a48575caa60348db8af9c3e578685b30 ✔️ openstack-meta-content-provider SUCCESS in 1h 52m 56s |
|
recheck |
|
/retest |
Migrate from gophercloud v1.14.1 to v2.8.0: - Update go.mod dependency and import paths - Add context parameters to API calls (List, Delete) - Handle DeleteResult return type from services.Delete() - Add Nova API version discovery endpoint in test fixture Gophercloud v2 requires context for all API operations and performs version discovery via GET / before other API calls. Updated test fixture to support this new behavior. Retained local Service struct in test fixture for test isolation and to avoid JSON marshalling complications with gophercloud v2's Service type. Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f9081931c92342a29253f57ee39a3536 ✔️ openstack-meta-content-provider SUCCESS in 1h 47m 12s |
|
/retest |
|
hmm seems zuul jobs no longer get triggered? same in this test PR #1037 |
|
recheck |
|
testing in #1037 a different nodeset, the same as configured for watcher. with this the job gets triggered at least. |
|
added a commit to this PR to configure the same nodeset as its configured in watcher. with this zuul checks in test PR #1037 got triggered and passed. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e66cd95080ab4daaa4988967aba57d76 ✔️ openstack-meta-content-provider SUCCESS in 39m 18s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/de62a9e9582e444db4a741a1ff3196ac ✔️ openstack-meta-content-provider SUCCESS in 3h 11m 54s |
remove that commit from this PR since there was a temporary issue with zuul jobs, not related to the configured nodeset. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ded104339ef84d22bce27b8830c973c0 ✔️ openstack-meta-content-provider SUCCESS in 45m 45s |
4 participants
Migrate from gophercloud v1.14.1 to v2.8.0:
Gophercloud v2 requires context for all API operations and performs version discovery via GET / before other API calls. Updated test fixture to support this new behavior.
Retained local Service struct in test fixture for test isolation and to avoid JSON marshalling complications with gophercloud v2's Service type.
Jira: OSPRH-18162
Jira: OSPRH-18319
Depends-On: openstack-k8s-operators/lib-common#645
Depends-On: openstack-k8s-operators/keystone-operator#635
AssistedBy: cloude-4-sonnet