fix: Add controller prefix to duplicate log messages #1598
Conversation
Two different controllers are watching the same Secret changes and both logging when they detect that a keystone-related resource has changed. This commit add controller prefix to both controllers: - Add [ControlPlane] prefix to OpenStackControlPlane controller log - Add [Client] prefix to OpenStackClient controller log Benefits: - Immediate differentiation of log sources - Low risk, minimal code changes - Maintains all existing functionality - Improved operator debugging experience Before: 'input source keystone changed, reconcile: nova - openstack' 'input source keystone changed, reconcile: nova - openstack' After: '[ControlPlane] input source keystone changed, reconcile: nova - openstack' '[Client] input source keystone changed, reconcile: nova - openstack' Fixes: #duplicate-logs Assisted by: claude-4-sonnet
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ratailor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a5b06c6471164a4c82dc4c9738b0d859 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 41s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/85d9cf555b7844c3a690627bc2b3a4aa ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 25m 33s |
|
/retest |
|
recheck |
2 participants
Two different controllers are watching the same Secret changes and both logging when they detect that a keystone-related resource has changed.
This commit add controller prefix to both controllers:
Benefits:
Before:
'input source keystone changed, reconcile: nova - openstack' 'input source keystone changed, reconcile: nova - openstack'
After:
'[ControlPlane] input source keystone changed, reconcile: nova - openstack'
'[Client] input source keystone changed, reconcile: nova - openstack'
Fixes: #duplicate-logs
Assisted by: claude-4-sonnet