Skip to content

Conversation

@fmount
Copy link
Contributor

@fmount fmount commented Sep 26, 2025

Modernize using gopls modernize tool to update:

  • Replace interface{} with any type alias (Go 1.18+)
  • Update range loops to use idiomatic range syntax
  • Replace fmt.Sprintf with fmt.Appendf where appropriate

These changes improve code readability and align with current Go best practices.

Co-Authored-By: Claude [email protected]

Applied automated modernization using gopls modernize tool to update:
- Replace interface{} with any type alias (Go 1.18+)
- Update range loops to use idiomatic range syntax
- Replace fmt.Sprintf with fmt.Appendf where appropriate

These changes improve code readability and align with current Go best
practices.

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Francesco Pantano <[email protected]>
@fmount fmount requested review from abays, dprince and stuggi September 26, 2025 10:13
@openshift-ci openshift-ci bot requested a review from fultonj September 26, 2025 10:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fmount
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ratailor
Copy link
Contributor

LGTM

@fmount
Copy link
Contributor Author

fmount commented Oct 1, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@fmount: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl 096fdc6 link true /test openstack-operator-build-deploy-kuttl
ci/prow/openstack-operator-build-deploy-kuttl-4-18 096fdc6 link true /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants