Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hardcoded multi session studies until #204 is complete #202

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

chrisbendel
Copy link
Collaborator

closes openstax/research#214

@chrisbendel chrisbendel requested a review from reedstrm October 24, 2022 16:05
@reedstrm
Copy link
Contributor

Is there an example deployment of this somewhere, or a screenshot?

Copy link
Member

@nathanstitt nathanstitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approach looks good but I think we can adjust the hardcoded times using the provided durationMinutes & points

</Box>
<Box css={{ color: colors.grayText }} direction='column'>
<small>Session 1: 20min 35pts</small>
<small>Session 2: 20min 35pts</small>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about instead of hardcoding 20 min 35pts we divide study.durationMinutes / study.parts.length?

@chrisbendel chrisbendel merged commit 6003d40 into main Nov 10, 2022
@chrisbendel chrisbendel deleted the 214-multisession-indicators branch November 10, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants