Port layouts/default files to TypeScript (CORE-1259) #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
typescript-layouts-default
branch
from
a6a763c to
942c139
Compare
- Convert 22 JavaScript files to TypeScript with comprehensive type definitions - Add proper prop typing for all React components following Roy's guidelines - Maintain existing functionality while adding type safety throughout - Create comprehensive test file with TypeScript validation tests Key improvements: - StickyData types for campaign/donation data structures - MenuStructure types for CMS-driven navigation menus - Safe localStorage wrapper types with incognito mode handling - Context and hook return types for shared state management - Proper event handler types for keyboard navigation and user interactions Files converted: - shared.js -> shared.tsx (core utilities and hooks) - header/header.js -> header.tsx (main header component) - All menu components with proper prop typing - Dialog and popup systems with context management - Welcome components with enhanced type safety - All supporting utility components Test coverage: - TypeScript type validation tests - Component integration tests - Hook behavior verification - Complex type interaction tests 🤖 Generated with [Claude Code](https://claude.ai/code) eslint --fix Co-Authored-By: Claude <[email protected]>
RoyEJohnson
force-pushed
the
typescript-layouts-default
branch
from
942c139 to
c8128f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Files converted
Core layout files:
shared.js->shared.tsx- shared utilities and hooks with StickyData typesheader/header.js->header.tsx- main header componentHeader menu system (8 files):
main-menu/main-menu.tsx- complex menu with dropdown navigation and CMS data typesmain-menu/dropdown/dropdown.tsx- dropdown menu component with proper event typingmain-menu/login-menu/*.tsx(2 files) - login menu componentsgive-button/give-button.tsx- donation button componentlogo/logo.tsx- site logo componentmenu-expander/menu-expander.tsx- mobile menu expanderDialog and popup systems (8 files):
takeover-dialog/*.tsx(6 files) - modal dialog system with context managementmicrosurvey-popup/*.tsx(3 files) - survey popup system with content typesAdditional components (4 files):
welcome/*.tsx(2 files) - user onboarding components with enhanced date safetylower-sticky-note/load-lsn-content.tsx- sticky note loaderheader/sticky-note/sticky-note.tsx- header sticky note with data typesKey TypeScript improvements
Test plan
any, prefertype, inline props)Resolves CORE-1259
🤖 Generated with Claude Code