Port src/app/layouts microsurvey-popup files from JS to TS #2800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
port-layouts-to-ts
branch
from
1ba7e46 to
6ea6d9b
Compare
RoyEJohnson
force-pushed
the
port-layouts-to-ts
branch
3 times, most recently
from
178052b to
1c3c12a
Compare
RoyEJohnson
reviewed
Dec 16, 2025
| <div | ||
| className="right-bg clipped-image" | ||
| style={{backgroundImage: `url(${bannerImgUrl});`}} | ||
| style={{backgroundImage: `url(${bannerImgUrl})`}} |
Contributor
There was a problem hiding this comment.
This was yesterday's hotfix. I just rolled it into this PR rather than make a separate one.
jivey
requested changes
Dec 18, 2025
Member
jivey
left a comment
jivey
left a comment
There was a problem hiding this comment.
Left some small type feedback, but the only blocker I see the queue test missing an assertion.
| const SEEN_ENOUGH = 3; | ||
|
|
||
| function StickyContent({stickyData, children}: {stickyData: StickyData | undefined; children: React.ReactNode}) { | ||
| const {body, link_url: url, link_text: text} = assertDefined(stickyData); |
Member
There was a problem hiding this comment.
To me, this assertion belongs in the caller (useBoundStickyContent?) because this component requires it to render, which is more clearly communicated by removing undefined from the type.
| render(<MemoryRouter initialEntries={['/']}> | ||
| <Component /> | ||
| </MemoryRouter>); | ||
| console.info('** Page', document.body.innerHTML); |
Member
There was a problem hiding this comment.
There aren't any assertions in this test?
| const QueuedItem = queue.length > 0 ? queue[0] : null; | ||
|
|
||
| useEnqueueWhenReady(useStickyMicrosurveyContent as UseContentHook, queue, setQueue); | ||
| useEnqueueWhenReady(useAdoptionMicrosurveyContent as UseContentHook, queue, setQueue); |
Member
There was a problem hiding this comment.
Up to you but I think I'd prefer adding onDone to all the types to keep the shape consistent and avoid the cast.
- Convert adoption-content.js to TypeScript with proper return types - Convert queue.js to TypeScript with typed queue and component types - Convert sticky-content.js to TypeScript with StickyData type - Add React.ComponentType for microsurvey components - Type all hook parameters and return values - Add proper types for cookie reducer and dismissal logic 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1. move assertDefined 2. add assertion to queue.test 3. Use QueuedItemType for adoption & sticky content
RoyEJohnson
force-pushed
the
port-layouts-to-ts
branch
from
93c69dc to
83c0405
Compare
jivey
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may need to be redone, since #2799 removed sticky-footer, including some code in the microsurvey stuff. Wait until it is merged to pick this up.
Summary
Converts JavaScript files in
src/app/layouts/default/microsurvey-popupto TypeScript as part of the migration effort tracked in CORE-1386.Changes
Guidelines Followed
anytypetypeoverinterfaceRelated Issue
https://openstax.atlassian.net/browse/CORE-1386
🤖 Generated with Claude Code