Skip to content

Core-1440: change upper menu tag from menu to ul #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoyEJohnson merged 2 commits into from
Dec 18, 2025
Merged

Core-1440: change upper menu tag from menu to ul #2808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ea29a2
Core-1440: change upper menu tag from menu to ul
RoyEJohnson Dec 17, 2025
137fb69
Mobile menu styles
RoyEJohnson Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/layouts/default/header/menus/menus.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
flex-direction: column;
}

ul {
ul:not(.container) {
font-size: 1.8rem;
font-weight: bold;
grid-row-gap: 2rem;
Expand Down
4 changes: 2 additions & 2 deletions src/app/layouts/default/header/menus/upper-menu/upper-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export default function UpperMenu() {
const riceLogo = useOptimizedImage('https://openstax.org/dist/images/rice.webp', 80);

return (
<menu className="container" data-analytics-nav="Upper Menu">
<ul className="container no-bullets" data-analytics-nav="Upper Menu">
{
menuData.map(
({label, url}) => <MenuItem key={label} label={label} url={url} showButton={showButton} />
Expand All @@ -53,6 +53,6 @@ export default function UpperMenu() {
<img src={riceLogo} alt="Rice University logo" height="30" width="79" />
</a></li>
{showButton ? <JITLoad importFn={importGiveButton} /> : null}
</menu>
</ul>
);
}
10 changes: 6 additions & 4 deletions src/app/layouts/landing/header/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,19 @@
}

@include width-up-to($tablet-max) {
menu,
ul,
.pseudo-menu {
padding-inline-start: 4rem;
margin-block: 0;
width: 100%;
}
menu li {
ul li {
float: left;
}
menu li:last-child {
ul li:last-child {
float: right;
}
menu:first-child {
ul:first-child {
display: none;
}
}
Expand Down