Skip to content

Core 1441+1442 footer link accessible names #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoyEJohnson merged 3 commits into from
Dec 18, 2025
Merged

Core 1441+1442 footer link accessible names #2809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a906727
Flex page footer links: remove duplicate and rearrange
RoyEJohnson Dec 17, 2025
67d96db
Give FAQ link a spelled-out aria-label
RoyEJohnson Dec 17, 2025
0166526
Merge branch 'main' into core-1441+1442-footer-link-accessible-names
RoyEJohnson Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/layouts/default/footer/footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function Footer({
<a href="https://help.openstax.org/s/">
Support Center
</a>
<a href="/faq">FAQ</a>
<a href="/faq" aria-label="frequently asked questions">FAQ</a>
<a href="/print/">Order Print</a>
<a href="https://status.openstax.org/">
System Status
Expand Down
5 changes: 2 additions & 3 deletions src/app/layouts/landing/footer/flex.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,14 @@ function FlexFooter({data}: Props) {
contactFormParams={contactFormParams}
/>
</button>
<a href="/tos">Terms of Use</a>
<a href="/privacy">Privacy Notice</a>
<CookieYesToggle />
</ListOfLinks>
</div>
<div className="column col2">
<ListOfLinks>
<a href="/accessibility-statement">Accessibility Statement</a>
<a href="/tos">Terms of Use</a>
<a href="/privacy">Privacy Notice</a>
<CookieYesToggle />
</ListOfLinks>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions test/src/layouts/layouts.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ describe('layouts/landing', () => {
/Unable to find an element/
);
// Default footer has 4 links + 1 link in layout = 5 links
expect(await screen.findAllByRole('link')).toHaveLength(5);
expect(await screen.findAllByRole('link')).toHaveLength(4);
});
it('rewrites footer links in portal', async () => {
const title = 'some-title';
Expand All @@ -128,6 +128,6 @@ describe('layouts/landing', () => {
// Default footer has 4 links + 1 link in layout = 5 links
const links = await screen.findAllByRole('link');

expect(links[1]).toHaveAttribute('href', '//a-portal/tos');
expect(links[1]).toHaveAttribute('href', '//a-portal/accessibility-statement');
});
});