Skip to content

Core 1443 restyle promote snippet heading #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoyEJohnson merged 3 commits into from
Dec 18, 2025
Merged

Core 1443 restyle promote snippet heading #2810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1658d9
Restyle promote snippet h2 so it looks like before
RoyEJohnson Dec 17, 2025
dc4e878
Promote Get The Book and Summary to h2
RoyEJohnson Dec 17, 2025
92c07d9
Merge branch 'main' into core-1443-restyle-promote-snippet-heading
RoyEJohnson Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/app/pages/details/desktop-view/details-tab/details-tab.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
grid-template-columns: auto auto;
}

h2 {
@include set-font(h3);
}

p,
h2,
h3 {
margin: 0;
}
Expand Down Expand Up @@ -65,11 +70,13 @@
}
}

h2,
h3,
h4 {
letter-spacing: normal;
}

h2,
h3 {
margin-bottom: 0.3rem;
}
Expand Down
12 changes: 6 additions & 6 deletions src/app/pages/details/desktop-view/details-tab/details-tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function PolishTab({model}: {model: ContextValues}) {
<div className="details-tab">
<div className="sidebar">
<div>
<h3>Przejdź do książki</h3>
<h2>Przejdź do książki</h2>
<GetThisTitle model={model} />
</div>
<div className="let-us-know-region">
Expand All @@ -28,7 +28,7 @@ function PolishTab({model}: {model: ContextValues}) {
</div>
<div className="main">
<div className="loc-summary-text">
<h3>Podsumowanie</h3>
<h2>Podsumowanie</h2>
<RawHTML html={model.description} />
</div>
<Authors />
Expand All @@ -44,12 +44,12 @@ function EnglishTab({model}: {model: ContextValues}) {
<div className="details-tab">
<div className="sidebar">
<div>
<h3>
<h2>
<FormattedMessage
id="getTheBook"
defaultMessage="Get the book"
/>
</h3>
</h2>
<GetThisTitle model={model} />
</div>
<div className="let-us-know-region">
Expand All @@ -59,12 +59,12 @@ function EnglishTab({model}: {model: ContextValues}) {
<div className="main">
<Promo promoteSnippet={model.promoteSnippet} />
<div className="loc-summary-text">
<h3>
<h2>
<FormattedMessage
id="summary"
defaultMessage="Summary"
/>
</h3>
</h2>
<RawHTML html={model.description} />
</div>
<Authors />
Expand Down
4 changes: 3 additions & 1 deletion src/app/pages/details/desktop-view/promo.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
padding: 1rem 1.5rem;
background-color: ui-color(page-bg);

h3 {
h2 {
@include set-font(h3);
letter-spacing: normal;
margin-bottom: 1rem;
}
}
4 changes: 2 additions & 2 deletions test/src/pages/details/desktop-view/details-tab.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ function Component(props: Props) {
describe('details-tab', () => {
it('renders (English)', () => {
render(<Component model={model} polish={false} />);
screen.getByRole('heading', {level: 3, name: 'Summary'});
screen.getByRole('heading', {level: 2, name: 'Summary'});
});
it('renders (Polish)', () => {
render(<Component model={model} polish={true} />);
screen.getByRole('heading', {level: 3, name: 'Przejdź do książki'});
screen.getByRole('heading', {level: 2, name: 'Przejdź do książki'});
});
});