Skip to content

Add analytics tracking attributes for key funnel links [CORE-1462] #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomWoodward merged 2 commits into from
Jan 7, 2026
Merged

Add analytics tracking attributes for key funnel links [CORE-1462] #2811

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebfeaf8
Add analytics tracking attributes to key funnel links
OpenStaxClaude Jan 7, 2026
e6a91ae
Remove redundant data-analytics-nav from tech partner list
OpenStaxClaude Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/pages/assignable/sections/banner/banner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export default function Banner({data}: {data: BannerData}) {
<h1>{data.subheading}</h1>
</div>
<RawHTML className="text-content" html={data.headingDescription} />
<div className="button-row">
<div className="button-row" data-analytics-nav="Assignable CTAs">
<CTAButton
header={data.addAssignableCtaHeader}
href={data.addAssignableCtaLink}
Expand Down
2 changes: 1 addition & 1 deletion src/app/pages/details/common/get-this-title-files/order-print-copy/order-print-copy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export default function OrderPrintCopy({slug}: {slug: string}) {
}

return (
<nav className="order-print-copy">
<nav className="order-print-copy" data-analytics-nav="Order print copy">
<PhoneBoxes {...{contentArray}} />
<DesktopBoxes {...{contentArray}} />
</nav>
Expand Down
2 changes: 1 addition & 1 deletion src/app/pages/details/common/let-us-know/let-us-know.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function ButtonWithIcon({url, icon, text, reverse=false}: {
reverse?: boolean;
}) {
return (
<a className="button-with-icon" href={url}>
<a className="button-with-icon" href={url} data-analytics-link>
<span className={cn('book-icon', {reverse})}>
<FontAwesomeIcon icon={icon} />
</span>
Expand Down
1 change: 1 addition & 0 deletions src/app/pages/details/desktop-view/instructor-resource-tab/partners/partners.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export default function Partners({
<div
className="blurb-scroller"
data-analytics-content-list={title}
data-analytics-nav={title}
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blurb-scroller div now has both data-analytics-content-list and data-analytics-nav attributes set to the same value (title). This creates redundant tracking and may lead to duplicate analytics events being fired for the same interaction. Consider whether both attributes are necessary, or if only one should be used for this element. Additionally, note that the parent title-bar div (line 48) already has data-analytics-nav={title}, which may create overlapping tracking contexts.

Suggested change
data-analytics-nav={title}

Copilot uses AI. Check for mistakes.
>
<ul className="blurbs">
{blurbs.map((blurb) => (
Expand Down