Skip to content

update selected border styles #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

update selected border styles #97

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a75a6de
update selected border styles
jivey Aug 18, 2025
f3568df
Merge branch 'main' into CORE-1117
jivey Aug 18, 2025
15f647c
bump package version
jivey Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export const buttonBarItemCss = css`

&[data-selected=true] {
background: ${colors.palette.neutralLight};
box-shadow: inset 0 0 0 0.1rem ${colors.palette.pale};
}
&:hover:not([data-selected=true]) {
background: ${colors.palette.neutralLighter};
Expand Down
2 changes: 2 additions & 0 deletions src/components/ToggleButtonGroup/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ export const StyledToggleButton = styled(ToggleButton)`

&[data-selected] {
background-color: ${colors.palette.neutralLighter};
// achieve a 2px border effect without disrupting layout
box-shadow: inset 0 0 0 0.1rem ${colors.palette.pale};
}

&[data-disabled] {
Expand Down
6 changes: 3 additions & 3 deletions src/components/__snapshots__/ButtonBar.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`ButtonBar renders 1`] = `
<DocumentFragment>
<div
class="sc-gsnTZi bqPtVr"
class="sc-gsnTZi hYiJLm"
>
<a>
One
Expand All @@ -18,7 +18,7 @@ exports[`ButtonBar renders 1`] = `
exports[`ButtonBar renders large size 1`] = `
<DocumentFragment>
<div
class="sc-gsnTZi eOLdKk"
class="sc-gsnTZi hZAvUF"
>
<button>
One
Expand All @@ -35,7 +35,7 @@ exports[`ButtonBar renders large size 1`] = `
exports[`ButtonBar renders small size 1`] = `
<DocumentFragment>
<div
class="sc-gsnTZi fgJhCT"
class="sc-gsnTZi gFPpQi"
>
<button>
One
Expand Down
6 changes: 3 additions & 3 deletions src/components/__snapshots__/Tabs.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`Tabs component button-bar styling renders 1`] = `
data-react-aria-hidden="true"
/>
<div
class="sc-bczRLJ kWkDUg"
class="sc-bczRLJ iBDygX"
data-orientation="horizontal"
data-rac=""
>
Expand Down Expand Up @@ -82,7 +82,7 @@ exports[`Tabs component button-bar styling renders large size 1`] = `
data-react-aria-hidden="true"
/>
<div
class="sc-bczRLJ kTnZrf"
class="sc-bczRLJ feXGds"
data-orientation="horizontal"
data-rac=""
>
Expand Down Expand Up @@ -158,7 +158,7 @@ exports[`Tabs component button-bar styling renders small size 1`] = `
data-react-aria-hidden="true"
/>
<div
class="sc-bczRLJ kFnuyo"
class="sc-bczRLJ kAIoyP"
data-orientation="horizontal"
data-rac=""
>
Expand Down
30 changes: 15 additions & 15 deletions src/components/__snapshots__/ToggleButtonGroup.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode multiple 1`] = `
>
<button
aria-pressed={true}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="red"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -39,7 +39,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode multiple 1`] = `
</button>
<button
aria-pressed={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="green"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -64,7 +64,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode multiple 1`] = `
</button>
<button
aria-pressed={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="blue"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -89,7 +89,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode multiple 1`] = `
</button>
<button
aria-pressed={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="yellow"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -114,7 +114,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode multiple 1`] = `
</button>
<button
aria-pressed={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="orange"
data-rac=""
data-react-aria-pressable={true}
Expand Down Expand Up @@ -153,7 +153,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode single 1`] = `
>
<button
aria-checked={true}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="red"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -180,7 +180,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode single 1`] = `
</button>
<button
aria-checked={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="green"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -206,7 +206,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode single 1`] = `
</button>
<button
aria-checked={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="blue"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -232,7 +232,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode single 1`] = `
</button>
<button
aria-checked={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="yellow"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -258,7 +258,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode single 1`] = `
</button>
<button
aria-checked={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="orange"
data-rac=""
data-react-aria-pressable={true}
Expand Down Expand Up @@ -298,7 +298,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode undefined 1`] = `
>
<button
aria-checked={true}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="red"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -325,7 +325,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode undefined 1`] = `
</button>
<button
aria-checked={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="green"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -351,7 +351,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode undefined 1`] = `
</button>
<button
aria-checked={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="blue"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -377,7 +377,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode undefined 1`] = `
</button>
<button
aria-checked={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="yellow"
data-rac=""
data-react-aria-pressable={true}
Expand All @@ -403,7 +403,7 @@ exports[`ToggleButtonGroup matches snapshot with selectionMode undefined 1`] = `
</button>
<button
aria-checked={false}
className="sc-dkzDqf ivRDBW"
className="sc-dkzDqf kCUTAu"
data-button-id="orange"
data-rac=""
data-react-aria-pressable={true}
Expand Down
Loading