Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding class for multiple ancestry LD calculation #670

Draft
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

addramir
Copy link
Contributor

@addramir addramir commented Jul 4, 2024

✨ Context

I provided the context on the last meeting.

πŸ›  What does this PR implement

πŸ™ˆ Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added size-L and removed size-M labels Jul 5, 2024
@github-actions github-actions bot added size-XL and removed size-L labels Jul 10, 2024
@addramir addramir marked this pull request as ready for review July 10, 2024 21:25
@addramir addramir requested a review from d0choa July 11, 2024 18:13
@d0choa
Copy link
Collaborator

d0choa commented Jul 12, 2024

I don't recommend including this in dev at this stage. At a minimum, it requires tests. Even with tests, I'm not sure it has reached the maturity to tell the world: You can start using this. It can live in its branch and be a draft PR if you want to increase awareness of the work happening here.

@addramir
Copy link
Contributor Author

Ok, sound reasonable. I will convert it back to draft then. Anyway, Im not planning working on this next month. So it will be in this state for a while.

@addramir addramir marked this pull request as draft July 12, 2024 09:41
@project-defiant project-defiant requested review from tskir and removed request for tskir July 18, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants