-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 99% credible set validation during study_locus_validation
#765
Conversation
We previously discussed 99% CS, not 95% to be more comprehensive. And actually removing it from coloc and everything else. |
It's doable, but we must fix a few other problems then. Let's discuss this in person |
I like the idea of having one single point in the process where things get dropped. Although pruning the locus object would is radically different from the validation of other datasets (as it would not lead to any new flagged objects and the filtered out tags would not get anywhere unlike invalid studies or study loci. They just disappear.) It would make sense to have it in the validation and would make the resulting datasets consistent across all applications.
To be honest, I don't really like this inconsistency. Would it be possible to make all cred.set dataset similar? Similarly, if we don't care about different levels of confidence, and would keep everything 99%, we can just drop the column from the schema. |
I need to adjust this PR based on the new decisions described on the ticket opentargets/issues#3468 |
study_locus_validation
study_locus_validation
Implementing the new decisions described on the ticket opentargets/issues#3468 is pretty simple. Now, all credible sets are annotated when we try to filter them. That would make all the logic work as long as the locus contains a populated We need to remember that the current PICS results are filtered to 95%, so much of this will not have an effect until we re-run PICS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All makes sense:
- Annotating PICSed credible sets upon creation.
- Filtering method has the logic to do the annotation as well.
- Filtering is happening at the validation step.
- As the dataset is already filtered, coloc doesn't need to apply filter anymore.
Includes:
Closes opentargets/issues#3468