Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add biosample index #769
feat: add biosample index #769
Changes from 21 commits
6fabc98
e8a3775
c4d6d5f
186e773
6f0a2e2
01917a7
55e2baf
692732b
30dc23f
28e1f92
33ebf58
26a4295
1c507e6
567d8e1
12293d3
850f910
c42bdd6
07daedc
fb98e15
b150122
4fb8d05
978f636
2364f8d
6f99147
ec4edf3
cf00504
ad947cb
729f492
1e660c2
ca4fce3
73b25da
c9eada2
f93b995
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a critique, rather a comment: we are doing exactly the same steps for genes (disease validation is more complicated). I'm wondering if we can have one function that would be used by both the biosample and gene validation... eg. We would pass the following parameters to this function:
Not exactly sure how to implement this, but sounds quite abstract that could be used in other places and other datasets maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After doing a few of these, the problem I see in abstracting this further is that the list of rules that decide when to add a flag is very diverse. Sometimes, it is just a filter, but sometimes, it has dependencies, aggregations, etc.
I'm referring to everything that leads to the second argument of
update_quality_flag
if this is what you mean here