Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ld clumping): a revised logic allows a more accurate clumping #772

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

DSuveges
Copy link
Contributor

a revised logic allows a more accurate identification of linked loci

✨ Context

It was noticed that in certain cases the LD based clumping was not performing as expected. After reviewing the logic, a proposed new implementation addresses the issue.

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added bug Something isn't working size-S Method Dataset labels Sep 18, 2024
@github-actions github-actions bot added size-M and removed size-S labels Sep 19, 2024
@DSuveges DSuveges linked an issue Sep 19, 2024 that may be closed by this pull request
@DSuveges DSuveges marked this pull request as ready for review September 19, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Dataset Method size-M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LD clumping doesn't work as intended
1 participant