feat: flag credible sets explained by SuSiE regions #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSuveges
reviewed
Sep 24, 2024
d0choa
commented
Sep 24, 2024
DSuveges
reviewed
Sep 24, 2024
src/gentropy/dataset/study_locus.py
Outdated
| # credible set in SuSiE overlapping region | ||
| f.col("inSuSiE") | ||
| # credible set not based on SuSiE | ||
| & ~(f.col("finemappingMethod") == "SuSiE-inf") |
There was a problem hiding this comment.
I think this condition is not needed as the source dataset (redundant_study_locus) is already filtered.
DSuveges
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
I think one of the filters is not needed, but otherwise all looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes opentargets/issues#3464
More background about the last changes in the issue