-
Notifications
You must be signed in to change notification settings - Fork 24
chore(docs): Fix unrenamed field in docs #2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important documentation discrepancy. It synchronizes the configuration guide with a prior change where a field related to preview features was renamed. The update ensures that users referencing the documentation will find accurate and up-to-date information regarding system configuration, preventing potential confusion or errors. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Old name, new name change, Docs now reflect the true state, Clarity takes hold. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation in docs/Configuring.md
to reflect the renaming of the preview_features
configuration field to preview
. This change correctly aligns the documentation with the actual implementation, as seen in other configuration files and source code. The markdown table formatting was also adjusted for better alignment. The change is correct and I have no further suggestions.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
@dmihalcik-virtru Can you please check if this results in chart changes and follow those up too? |
It looks like @c-r33d fixed the chart in opentdf/charts#148 already (august 2025) |
Proposed Changes
preview_features
topreview
Checklist
Testing Instructions