Skip to content

Conversation

dmihalcik-virtru
Copy link
Member

Proposed Changes

  • at some point we renamed preview_features to preview

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner October 3, 2025 19:18
@github-actions github-actions bot added the docs Documentation label Oct 3, 2025
Copy link
Contributor

Summary of Changes

Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important documentation discrepancy. It synchronizes the configuration guide with a prior change where a field related to preview features was renamed. The update ensures that users referencing the documentation will find accurate and up-to-date information regarding system configuration, preventing potential confusion or errors.

Highlights

  • Documentation Update: The documentation for configuring the system has been updated to reflect a previous field rename from preview_features to preview.
  • Field Name Correction: Specifically, references to preview_features.ec_tdf_enabled and preview_features.key_management have been corrected to preview.ec_tdf_enabled and preview.key_management in docs/Configuring.md.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Old name, new name change, Docs now reflect the true state, Clarity takes hold.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the size/s label Oct 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in docs/Configuring.md to reflect the renaming of the preview_features configuration field to preview. This change correctly aligns the documentation with the actual implementation, as seen in other configuration files and source code. The markdown table formatting was also adjusted for better alignment. The change is correct and I have no further suggestions.

Copy link
Contributor

github-actions bot commented Oct 3, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 186.238845ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 96.794249ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 367.979781ms
Throughput 271.75 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 38.216278604s
Average Latency 380.612759ms
Throughput 130.83 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 26.405928193s
Average Latency 263.176117ms
Throughput 189.35 requests/second

@jp-ayyappan
Copy link

@dmihalcik-virtru Can you please check if this results in chart changes and follow those up too?

@dmihalcik-virtru dmihalcik-virtru added this pull request to the merge queue Oct 7, 2025
@dmihalcik-virtru
Copy link
Member Author

@dmihalcik-virtru Can you please check if this results in chart changes and follow those up too?

It looks like @c-r33d fixed the chart in opentdf/charts#148 already (august 2025)

Merged via the queue into main with commit b9c188c Oct 7, 2025
35 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the DSPX-1600-renames branch October 7, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants